Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): improve use of breakpoint priorities #955

Merged
merged 1 commit into from
Dec 30, 2018

Commits on Dec 30, 2018

  1. fix(core): improve use of breakpoint priorities

    Use breakpoint priority as the only sorting/scanning mechanism;
    used to ensure correct MediaChange event notifications.
    
    * prioritize breakpoints: non-overlaps hightest, lt- lowest
      * consistently sort breakpoints ascending by priority
      * highest priority === smallest range
      * remove hackery with reverse(), etc.
    * memoize BreakPointRegistry findBy lookups
    * fix MatchMedia::observe() to support lazy breakpoint registration
    * fix fragile logic in MediaMarshaller
    * fix breakpoint registration usage
    * clarify update/clear builder function callbacks
    * fix MediaObserver breakpoint registration usage
    
    Fixes #648, Fixes #426
    ThomasBurleson committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    765afe2 View commit details
    Browse the repository at this point in the history