Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs titles clipped on the left side - anchors not accessible #891

Merged
merged 1 commit into from Dec 24, 2020

Conversation

abhishek2303
Copy link
Contributor

@abhishek2303 abhishek2303 commented Nov 21, 2020

Fixes the visibility of the anchor titles documentation UI which is currently clipped. This is done by assigning CSS overflow: visible property to the parent component - component-overview.

Fixes 20687

Before
Screenshot 2020-11-22 at 4 54 14 AM

After
Screenshot 2020-11-22 at 4 54 47 AM

The approach mentioned in 20687 suggests removing the margin of -30px from header-link. This would make the header text start after 30px with nothing in between. The approach in this PR is taken to overcome this visual oddity.

@google-cla
Copy link

google-cla bot commented Nov 21, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Nov 21, 2020
@abhishek2303
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 21, 2020
@abhishek2303 abhishek2303 changed the title Overflow component-overview to make anchor links visible Docs titles clipped on the left side - anchors not accessible Nov 21, 2020
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I also confirmed that this doesn't regress #856.

@crisbeto crisbeto merged commit 0e9ef1a into angular:master Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs titles are clipped on the left side
2 participants