Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

Commit

Permalink
fix(select): remove broken ARIA attributes
Browse files Browse the repository at this point in the history
Removes ARIA attributes unnecessary for combobox role that failed to match elements not in the DOM
  • Loading branch information
Marcy Sutton committed Apr 16, 2015
1 parent 70fc629 commit aaa6e5a
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 9 deletions.
2 changes: 0 additions & 2 deletions src/components/select/select.js
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,6 @@ function SelectDirective($mdSelect, $mdUtil, $mdTheming, $interpolate, $compile,
element.attr({
'role': 'combobox',
'id': 'select_' + $mdUtil.nextUid(),
'aria-haspopup': true,
'aria-expanded': 'false',
'aria-labelledby': labelEl.attr('id')
});
Expand Down Expand Up @@ -760,7 +759,6 @@ function SelectProvider($$interimElementProvider) {

function configureAria() {
opts.selectEl.attr('aria-labelledby', opts.target.attr('id'));
opts.target.attr('aria-owns', opts.selectEl.attr('id'));
opts.target.attr('aria-expanded', 'true');
}

Expand Down
7 changes: 0 additions & 7 deletions src/components/select/select.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -561,13 +561,6 @@ describe('<md-select-menu>', function() {
selectMenus.remove();
}));

it('sets up the aria-owns attribute', inject(function($document) {
openSelect(el);
var selectMenu = $document.find('md-select-menu');
var selectMenuId = selectMenu.attr('id');
expect(selectMenuId.length).toBeTruthy();
expect(el.attr('aria-owns')).toBe(selectMenuId);
}));
it('sets up the aria-labeledby attribute', inject(function($document) {
openSelect(el);
var selectId = el.attr('id');
Expand Down

0 comments on commit aaa6e5a

Please sign in to comment.