This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(list): add rel to copied attributes for md-list-item buttons …
#10352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngular#10351 This is to add support for rel attribute to be copied to generated links.
googlebot
added
the
cla: yes
|
Thanks for the PR. I think we should add a test for this new change? |
|
@pr4v33n - please add at least 2 unit tests for this change. |
ThomasBurleson
added
the
needs: unit tests
ThomasBurleson
added
needs: presubmit
and removed
needs: unit tests
kara
added
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…#10351
This is to add support for rel attribute to be copied to generated links.
See https://developers.google.com/web/tools/lighthouse/audits/noopener for more details.