Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(tabs): provide guidance on how to navigate between tabs #11402

Merged
merged 1 commit into from
Aug 14, 2018

Conversation

Splaktar
Copy link
Member

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

No guidance is given by AngularJS Material or screen readers on how users should navigate between tabs. It is documented in WAI-ARIA Authoring Practices for Tab Panel but many users are not familiar with this.

Issue Number:
Fixes #10895

What is the new behavior?

provide guidance on how to navigate between tabs
make sure that this message can be overridden in non-English locales

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

make sure that this message can be overridden in non-English locales

Fixes #10895
@Splaktar Splaktar added type: enhancement a11y This issue is related to accessibility g3: reported The issue was reported by an internal or external product team. labels Aug 10, 2018
@Splaktar Splaktar added this to the 1.1.11 milestone Aug 10, 2018
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Aug 10, 2018
@Splaktar Splaktar added pr: merge ready This PR is ready for a caretaker to review P3: important Important issues that really should be fixed when possible. ux: polish labels Aug 10, 2018
@mmalerba mmalerba merged commit 4b1b729 into master Aug 14, 2018
@Splaktar Splaktar deleted the improveTabsA11y branch August 14, 2018 17:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11y This issue is related to accessibility cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ g3: reported The issue was reported by an internal or external product team. P3: important Important issues that really should be fixed when possible. pr: merge ready This PR is ready for a caretaker to review type: enhancement ux: polish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tab: navigation issues with screen readers
3 participants