Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(autocomplete): two chips added on enter w/ IE11 #11528

Merged
merged 1 commit into from
Jan 7, 2019

Conversation

Splaktar
Copy link
Member

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Pressing enter to add a chip can cause two chips to be created in certain cases on IE11.

Issue Number:
Fixes #10640. Closes #10667.

What is the new behavior?

Pressing enter to add a chip no longer can cause two chips to be created in certain cases on IE11.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Many thanks to @RudolfFrederiksen for helping debug this and come up with a solution.

@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Nov 29, 2018
@Splaktar Splaktar self-assigned this Nov 29, 2018
@Splaktar Splaktar added a11y This issue is related to accessibility browser: IE This issue is specific to Internet Explorer P3: important Important issues that really should be fixed when possible. labels Nov 29, 2018
@Splaktar Splaktar added this to the 1.1.12 milestone Nov 29, 2018
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Nov 29, 2018
@Splaktar Splaktar assigned jelbourn and mmalerba and unassigned jelbourn Dec 20, 2018
@Splaktar Splaktar modified the milestones: 1.1.12, 1.1.13 Jan 3, 2019
@mmalerba mmalerba merged commit 705c54e into master Jan 7, 2019
@Splaktar Splaktar deleted the chipsAutocomplete-enterKeyTwoChipsIE11 branch January 7, 2019 20:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11y This issue is related to accessibility browser: IE This issue is specific to Internet Explorer cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P3: important Important issues that really should be fixed when possible. pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chips(autocomplete): when no match required, 2 chips created on 'enter' key
4 participants