Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

checkbox: aria-checked attribute gives unexpected results #12046

Closed
sharonlevyex opened this issue Nov 12, 2020 · 1 comment · Fixed by #12047
Closed

checkbox: aria-checked attribute gives unexpected results #12046

sharonlevyex opened this issue Nov 12, 2020 · 1 comment · Fixed by #12047
Assignees
@Splaktar
Labels
a11y This issue is related to accessibility has: Pull Request A PR has been created to address this issue P2: required Issues that must be fixed. type: bug
Milestone
1.2.2

Comments

@sharonlevyex
Copy link

Bug Report

In md-checkbox, when unchecking the sub checkboxes the screen reader reads "half checked" on the main checkbox even though it's supposed to read "not checked".

Demo and steps to reproduce the issue

Demo URL*: go to select all demo in https://material.angularjs.org/1.2.1/demo/checkbox
image

Detailed Reproduction Steps

  1. uncheck checkbox 1
  2. now the select all should be unchecked
  3. See that the select all checkbox has aria-checked="mixed" attribute.

Explain the expected behavior

After unselecting all checkboxes the aria-checked attribute is supposed to be "false".

Explain the current behavior

After unselecting all checkboxes the aria-checked attribute is "mixed".
@sharonlevyex sharonlevyex added needs triage Issues that need initial triage type: bug labels Nov 12, 2020
@Splaktar Splaktar changed the title Accessibility issue - md-checkbox aria-checked attribute gives unexpected results. checkbox: aria-checked attribute gives unexpected results Nov 15, 2020
@Splaktar Splaktar added the a11y This issue is related to accessibility label Nov 15, 2020
@Splaktar Splaktar self-assigned this Nov 15, 2020
@Splaktar Splaktar added this to the 1.2.2 milestone Nov 15, 2020
@Splaktar
Copy link
Member

Splaktar commented Nov 15, 2020 •
edited

Thank you for this report! I verified this on 1.1.0, 1.2.1, and HEAD. the md-indeterminate class is removed from the select all checkbox, but the aria-checked state is not updated properly.

@Splaktar Splaktar added P2: required Issues that must be fixed. and removed needs triage Issues that need initial triage labels Nov 15, 2020
Splaktar added a commit that referenced this issue Nov 15, 2020
@Splaktar
fix(checkbox): aria-checked state is not computed correctly in all cases
c9250bb 
Fixes #12046
@Splaktar Splaktar added the has: Pull Request A PR has been created to address this issue label Nov 15, 2020
@Splaktar Splaktar mentioned this issue Nov 15, 2020
Merged
3 tasks
Splaktar added a commit that referenced this issue Nov 16, 2020
@Splaktar
fix(checkbox): aria-checked state is not computed correctly in all cases
c609385 
Fixes #12046
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Splaktar Splaktar

Labels
a11y This issue is related to accessibility has: Pull Request A PR has been created to address this issue P2: required Issues that must be fixed. type: bug
Projects
None yet
Milestone
1.2.2
Development

Successfully merging a pull request may close this issue.

fix(checkbox): aria-checked state is not computed correctly in all cases angular/material
2 participants
@Splaktar @sharonlevyex