Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

md-input-container: growTextarea should be optional and should be possible to set max height #1209

Closed
yarl opened this issue Jan 16, 2015 · 12 comments
Closed

md-input-container: growTextarea should be optional and should be possible to set max height #1209

yarl opened this issue Jan 16, 2015 · 12 comments
Assignees
@ThomasBurleson
Milestone
1.0-rc1

Comments

@yarl
Copy link
Contributor

yarl commented Jan 16, 2015

  1. md-input-container needs parameter that disables autogrow of <textarea>.
  2. There should be possible to set maximum height of <textarea> inside md-input-container if autogrow is enabled. If text height inside is bigger than <textarea> height, overflow scrollbar should appear.
@ThomasBurleson ThomasBurleson modified the milestone: 0.7.1 Jan 19, 2015
@naomiblack naomiblack modified the milestones: 0.7.1, 0.8.0 Jan 26, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 0.8.0, 0.9.0 Jan 30, 2015
@DmitryEfimenko
Copy link

+1

@eckyputrady
Copy link

+1!

@no-more
Copy link

no-more commented Mar 16, 2015

+1

3 similar comments
@rahul18gupta
Copy link

+1

@sazonenka
Copy link

+1

@peterpisljar
Copy link

+1

@ereztison
Copy link

A possible workaround though not perfect is to wrap the md-input-container containing the textarea with the following div:

<div style="height: 7rem; overflow-y: auto;" scroll-glue>
</div>

I used scroll-glue directive to keep the containing div scroll stick to the bottom while its height is growing:
https://github.com/Luegg/angularjs-scroll-glue

@sazonenka
Copy link

@ereztison Unfortunately, your "div" was cut off. Could you, please, provide it once again?

@breezewish
Copy link
Contributor

+1

@ereztison
Copy link

@sazonenka: I updated my comment, you're welcome to take a look.

@sazonenka
Copy link

@ereztison Thanks!

@crrazymind
Copy link

+1

@marcysutton marcysutton modified the milestones: 0.10.0, 0.9.0 Apr 14, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 0.10.0, 0.11.0 Jun 16, 2015
@ThomasBurleson ThomasBurleson removed this from the 0.10.0 milestone Jun 16, 2015
@nantunes nantunes mentioned this issue Jul 1, 2015
Closed
Splaktar pushed a commit that referenced this issue Jul 4, 2015
@nantunes @Splaktar
fix(input, textarea): makes textarea autogrow optional, resolves #1209
c80d80a 
Fixes textarea auto grow inside scrollable container (resolves #2007 and possibly others)
Adds support for textarea auto grow based on rows attribute (resolves #2006)
Avoid "rows" attribute unintended overwrite by default value

Fixes #1209. Fixes #2007. Fixes #2006. Closes #3544.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ThomasBurleson ThomasBurleson

Labels
None yet
Projects
None yet
Milestone
1.0-rc1
Development

Successfully merging a pull request may close this issue.

Adds support for textarea's "rows" attribute and makes autogrow optional