md-discrete sliders often does not snap to nearest step

[LuminescentMoon]

This issue has appeared in the last 2-3 days. An example of this issue can be found here.

[ThomasBurleson]

@robertmesserle - something is messed up... is mdGestures interfering?

[mckenzielong]

In slider.js, the slider position is never being updated after the drag / event. The slider position is set in onPressDown at the beginning of the event, but as I mentioned, not after the event. Add setSliderPercentage call after the model is updated?

    function onPressUp(ev) {
      if (isDisabledGetter()) return;

      element.removeClass('dragging active');

      var exactVal = percentToValue( positionToPercent( ev.pointer.x ));
      var closestVal = minMaxValidator( stepValidator(exactVal) );
      scope.$apply(function() {
        setModelValue(closestVal);
        setSliderPercent( valueToPercent(closestVal));
      });
    }

Kind of unrelated, but should there be a blur call in here?

[ThomasBurleson]

@robertmesserle - is this an issue with $mdGesture ?

[robertmesserle]

@ThomasBurleson I haven't had a chance to look into it yet, but that's what I suspect.

Update: After looking into it, $mdGesture looks to be firing properly. I added a fix. Seems like a minor difference in the way the events were fired may have been the cause, but I'm not entirely sure.

[mckenzielong]

This was introduced by this change: 7028a75

Adding this back into onDragEnd also resolves the issue -- either way there was a missing call to setSliderPercent.

var exactVal = percentToValue( positionToPercent( ev.pointer.x ));
var closestVal = minMaxValidator( stepValidator(exactVal) );
setSliderPercent( valueToPercent(closestVal));

Edit: disregard the bit about re-adding to onDragEnd. Adding that code in onDragEnd reintroduces unintended 'click' behavior...