This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
fix(mdChips): Run duplicate check after mdOnAppend. #4113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topherfangio
added
the
pr: merge ready
|
@typotter ready for review :-) |
|
LGTM |
The duplicate check was firing before the user's onAppend method had a chance to run, so the check would always compare a string against an object and fail. fixes #2748
topherfangio
force-pushed
the
chips-fix-2748
branch
from
54995cc
to
7cd8c3b
Compare
kennethcachia
pushed a commit
to kennethcachia/material
that referenced
this pull request
Sep 23, 2015
The duplicate check was firing before the user's onAppend method had a chance to run, so the check would always compare a string against an object and fail. fixes angular#2748. closes angular#4113.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The duplicate check was firing before the user's onAppend
method had a chance to run, so the check would always
compare a string against an object and fail.
fixes #2748