This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
feat(dialog): added fullscreen option to dialog #5793
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EladBezalel
force-pushed
the
feat/dialog-sm-fullscreen
branch
2 times, most recently
from
385c55d
to
95aeadd
Compare
|
I will change this to be consistent with Layouts and md- attributes: |
|
fullscreen is only dialog feature, are you sure it should be in layouts? |
|
I am sure: if you are using a breakpoint syntax then we must be consistent. |
|
how are you going to implement it? |
Added `fullscreen` option that if it's set to true `.md-dialog-fullscreen` class is added to `<md-dialog>` that maximizing the dialog to the whole screen. fixes #2148
EladBezalel
force-pushed
the
feat/dialog-sm-fullscreen
branch
from
95aeadd
to
4f18e44
Compare
EladBezalel
changed the title
ThomasBurleson
added
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
fullscreenoption that if it's set to true.md-dialog-fullscreenclass is added to<md-dialog>that maximizing the dialog to the whole screen.fixes #2148