Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

rc5 md-dialog fullscreen works only for small screen #5924

Closed
stunaz opened this issue Nov 26, 2015 · 1 comment
Closed

rc5 md-dialog fullscreen works only for small screen #5924

stunaz opened this issue Nov 26, 2015 · 1 comment
Labels
resolution: works as expected The functionality works as designed and documented.

Comments

@stunaz
Copy link

stunaz commented Nov 26, 2015

why add the media condition @media (max-width: $layout-breakpoint-sm)

@media (max-width: $layout-breakpoint-sm) {
  md-dialog.md-dialog-fullscreen {
    min-height: 100%;
    min-width: 100%;
    border-radius: 0;
  }
}

This means we can't force a full screen on a big screen

@devversion
Copy link
Member

I think this is by intention. See at the Material Specs (http://www.google.com/design/spec/components/dialogs.html#dialogs-full-screen-dialogs)

References #5793

@ThomasBurleson ThomasBurleson added the resolution: won't fix There are no resources to fix this issue, the priority is too low, or it doesn't align w/ MD spec. label Dec 4, 2015
SpikesCafe-google added a commit to SpikesCafe-google/material that referenced this issue Jul 14, 2016
cleanup $mdMedia references in example. fullscreen only applies when the screen is xs and sm even when set to true.

See also angular#5924
ThomasBurleson pushed a commit that referenced this issue Jul 14, 2016
cleanup $mdMedia references in example.
fullscreen only applies when the screen is xs and sm even when set to true.

fixes #5924. Closes #9032.
@Splaktar Splaktar added resolution: works as expected The functionality works as designed and documented. and removed resolution: won't fix There are no resources to fix this issue, the priority is too low, or it doesn't align w/ MD spec. labels Apr 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolution: works as expected The functionality works as designed and documented.
Projects
None yet
Development

No branches or pull requests

4 participants