Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

Support for required field indicator #6647

Closed
ThomasBurleson opened this issue Jan 12, 2016 · 14 comments
Closed

Support for required field indicator #6647

ThomasBurleson opened this issue Jan 12, 2016 · 14 comments
Assignees
Labels
g3: reported The issue was reported by an internal or external product team. P3: important Important issues that really should be fixed when possible.

Comments

@ThomasBurleson
Copy link
Contributor

No description provided.

@ThomasBurleson ThomasBurleson added this to the 1.2.0 milestone Jan 12, 2016
@ThomasBurleson ThomasBurleson added priority: high g3: reported The issue was reported by an internal or external product team. and removed priority: high labels Jan 12, 2016
@devversion
Copy link
Member

Is this related to an Asterisk? Or what is meant by that?

@bourey
Copy link

bourey commented Jan 12, 2016

Yes. Here's a link to the latest Material spec for required fields: https://www.google.com/design/spec/components/text-fields.html#text-fields-required-fields

@devversion
Copy link
Member

Oh okay I was wondering, because I already created a PR, which is ready for merge, a few days ago.
See #6518 Whats now 😄 ?

@ThomasBurleson ThomasBurleson added P3: important Important issues that really should be fixed when possible. and removed priority: high labels Jan 13, 2016
@ThomasBurleson ThomasBurleson modified the milestones: 1.2.0, Backlog Jan 15, 2016
@devversion
Copy link
Member

@ThomasBurleson Needs to be closed

@kuhnroyal
Copy link

This is very nice, could you add that to md-select as well? Should be a quick fix and keeps the inputs consistent. Maybe even datepicker/autocomplete?

@kuhnroyal
Copy link

Two things I noticed:

  • doesn't work with ng-required
  • asterisk is always red when the field is focused, should probably have the theme color until it is invalid?

@devversion
Copy link
Member

Can't reproduce. Maybe create another issue with a demo. Already noticed the ng-required problem, but this relates to the given compontents.

@kuhnroyal
Copy link

https://material.angularjs.org/HEAD/demo/input
Focus one of the required fields, label is blue and asterisk is red.

@devversion
Copy link
Member

@kuhnroyal - See #6978, everything works as expected. The only thing which is an issue, is the ng-required

@kuhnroyal
Copy link

@devversion Yea I just checked the spec, thanks.

@devversion
Copy link
Member

@kuhnroyal Can you create a new issue for the ng-required, then I can reference it correctly?

@kuhnroyal
Copy link

Created #7105 to track ng-required support.

@corentin-gautier
Copy link

@devversion is there a support for the required asterisk on md-select ?

@devversion devversion self-assigned this Apr 7, 2016
@devversion
Copy link
Member

@corentin-gautier No not yet, please file another issue and ping me there.

@Splaktar Splaktar removed this from the - Backlog milestone Feb 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
g3: reported The issue was reported by an internal or external product team. P3: important Important issues that really should be fixed when possible.
Projects
None yet
Development

No branches or pull requests

6 participants