This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
interim stack order (multiple dialog) #6912
Labels
P1: urgent
Urgent issues that should be addressed in the next minor or patch release.
pr: merge ready
This PR is ready for a caretaker to review
Milestone
Comments
not exactly |
Did you even took a look? The stack order using the new queue count works perfectly. |
already commented under your issue |
ThomasBurleson
added
the
P1: urgent
Urgent issues that should be addressed in the next minor or patch release.
label
Jan 30, 2016
the dialog 4 is the last shown dialog (if modal , you can only click button on dialog 4) |
Alright, so this isn't related to my PR.. |
yeah.. but your logic is right , so really can fix my issue :P |
EladBezalel
added a commit
that referenced
this issue
Feb 6, 2016
* Cancel called shift which slices the first element in the Array instead of pop who take the last and also happens on `hide` fixes #6912
EladBezalel
added a commit
that referenced
this issue
Feb 26, 2016
* Cancel called shift which slices the first element in the Array instead of pop who take the last and also happens on `hide` fixes #6912
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
P1: urgent
Urgent issues that should be addressed in the next minor or patch release.
pr: merge ready
This PR is ready for a caretaker to review
version @ 1.0.4 & master
why
hide
andcancel
has different order?That cause sub-dialog
hide
self to parent, butcancel
from parent to self.here is the plunker
line 296
line 363
line 335
The text was updated successfully, but these errors were encountered: