Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

interim stack order (multiple dialog) #6912

Closed
GongT opened this issue Jan 29, 2016 · 8 comments
Closed

interim stack order (multiple dialog) #6912

GongT opened this issue Jan 29, 2016 · 8 comments
Assignees
Labels
P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: merge ready This PR is ready for a caretaker to review
Milestone

Comments

@GongT
Copy link

GongT commented Jan 29, 2016

version @ 1.0.4 & master

why hide and cancel has different order?

That cause sub-dialog hide self to parent, but cancel from parent to self.

here is the plunker

line 296

  function show(options) {
    ....
    stack.push(interimElement);
    ....

line 363

  function cancel(reason, options) {
    var interim = stack.shift();
    ....

line 335

  function hide(reason, options) {
    ....
    var interim = stack.pop();
    ....
@GongT GongT changed the title interim stack order interim stack order (multiple dialog) Jan 29, 2016
@devversion
Copy link
Member

Hello,

This is a side-effect of #6684, which fixes that issue too. Just give it a try :)
So this issue is fixed in #6684

@GongT
Copy link
Author

GongT commented Jan 30, 2016

not exactly

@devversion
Copy link
Member

Did you even took a look? The stack order using the new queue count works perfectly.

@GongT
Copy link
Author

GongT commented Jan 30, 2016

already commented under your issue

@devversion
Copy link
Member

Using the changes from the PR:

-> Hide works as expected.

-> Cancel works as expected.

So what isn't exactly working? Everything works as desired in the plunker?

@ThomasBurleson ThomasBurleson added the P1: urgent Urgent issues that should be addressed in the next minor or patch release. label Jan 30, 2016
@ThomasBurleson ThomasBurleson added this to the 1.0.5 milestone Jan 30, 2016
@GongT
Copy link
Author

GongT commented Jan 30, 2016

the dialog 4 is the last shown dialog (if modal , you can only click button on dialog 4)
if you click hide & cancel from 4 to 1 ,you will see different

@devversion
Copy link
Member

Alright, so this isn't related to my PR..

@GongT
Copy link
Author

GongT commented Jan 30, 2016

yeah.. but your logic is right , so really can fix my issue :P

@ThomasBurleson ThomasBurleson modified the milestones: 1.0.5, 1.0.6 Feb 4, 2016
EladBezalel added a commit that referenced this issue Feb 6, 2016
* Cancel called shift which slices the first element in the Array instead of pop who take the last and also happens on `hide`

fixes #6912
@EladBezalel EladBezalel added the pr: merge ready This PR is ready for a caretaker to review label Feb 6, 2016
EladBezalel added a commit that referenced this issue Feb 26, 2016
* Cancel called shift which slices the first element in the Array instead of pop who take the last and also happens on `hide`

fixes #6912
ThomasBurleson pushed a commit that referenced this issue Mar 1, 2016
* Cancel called shift which slices the first element in the Array instead of pop who take the last and also happens on `hide`

fixes #6912

  Closes #7053
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P1: urgent Urgent issues that should be addressed in the next minor or patch release. pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants