Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

interim stack order (multiple dialog) #6912

@GongT

Description

@GongT

version @ 1.0.4 & master

why hide and cancel has different order?

That cause sub-dialog hide self to parent, but cancel from parent to self.

here is the plunker

line 296

  function show(options) {
    ....
    stack.push(interimElement);
    ....

line 363

  function cancel(reason, options) {
    var interim = stack.shift();
    ....

line 335

  function hide(reason, options) {
    ....
    var interim = stack.pop();
    ....

Metadata

Metadata

Assignees

Labels

P1: urgentUrgent issues that should be addressed in the next minor or patch release.pr: merge readyThis PR is ready for a caretaker to review

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions