Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(chips): do not trim the input model. #7748

Closed
wants to merge 1 commit into from
Closed

fix(chips): do not trim the input model. #7748

wants to merge 1 commit into from

Conversation

devversion
Copy link
Member

  • The chips input should not trim the text, because otherwise the buffer will be always falsey, even when there are spaces in the input, and this would cause the backspace not to work.

Fixes #7243

@devversion devversion added the needs: review This PR is waiting on review from the team label Mar 25, 2016
@topherfangio
Copy link
Contributor

Looks good, but do you think we should trim any new chips so that users don't accidentally add spaces into a chip?

@devversion
Copy link
Member Author

@topherfangio I like the idea. I will implement that and let you know.

@devversion
fix(chips): do not trim the input model.
bdab7c4 
* The chips input should not trim the text, because otherwise the buffer will be always falsey, even when there are spaces in the input, and this would cause the backspace not to work.

Fixes angular#7243
@devversion devversion added pr: merge ready This PR is ready for a caretaker to review and removed needs: review This PR is waiting on review from the team labels Mar 28, 2016
ThomasBurleson pushed a commit that referenced this pull request Apr 1, 2016
@devversion @ThomasBurleson
fix(chips): do not trim the input model.
c305791 
* The chips input should not trim the text, because otherwise the buffer will be always falsey, even when there are spaces in the input, and this would cause the backspace not to work.

Fixes #7243

Closes #7748

# Conflicts:
#	src/components/chips/js/chipsController.js
ThomasBurleson pushed a commit that referenced this pull request Apr 1, 2016
@devversion @ThomasBurleson
fix(chips): do not trim the input model.
d7c389d 
* The chips input should not trim the text, because otherwise the buffer will be always falsey, even when there are spaces in the input, and this would cause the backspace not to work.

Fixes #7243

Closes #7748

# Conflicts:
#	src/components/chips/js/chipsController.js
gmoothart pushed a commit to gmoothart/material that referenced this pull request Apr 5, 2016
@devversion @gmoothart
fix(chips): do not trim the input model.
1c01ec5 
* The chips input should not trim the text, because otherwise the buffer will be always falsey, even when there are spaces in the input, and this would cause the backspace not to work.

Fixes angular#7243

Closes angular#7748
@devversion devversion deleted the fix/chips-trim branch April 21, 2016 12:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@ThomasBurleson ThomasBurleson

Labels
pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devversion @topherfangio @ThomasBurleson