feat/bug: md-button mdNoFocusStyle not working for md-list-item / md-card #8691
Comments
The approach with the Once we introduce a constant, like this, the API will get really confusing and users expect the same constants for other components as well. The focus style can be easily overwritten per CSS - I know you talked about the promise chain, but this is IMO not a big deal, because otherwise we will have to introduce this to other components with $q promises as well (as said above) Indeed, we should probably support the @graphefruit What is about the card component - Can you explain it a bit? |
* Adds support for `md-no-focus-style` attribute forwarding * Add documentation for `md-menu` as proxy item * Enhance tests for `md-menu` inside of `md-list-item` Closes angular#8691.
@devversion sorry for late response, got no PC. Thanks so far & have a great week |
* Refactors `md-no-focus-style` attribute into the `md-no-focus` class. * Adds support for `md-no-focus` class forwarding for the list item. * Add documentation for `md-menu` as proxy item * Enhance tests for `md-menu` inside of `md-list-item` BREAKING CHANGE: `md-no-focus-style` attribute on `md-button` is now a class (`.md-no-focus`) Closes angular#8691.
* Refactors `md-no-focus-style` attribute into the `md-no-focus` class. * Adds support for `md-no-focus` class forwarding for the list item. * Add documentation for `md-menu` as proxy item * Enhance tests for `md-menu` inside of `md-list-item` BREAKING CHANGE: `md-no-focus-style` attribute on `md-button` is now a class (`.md-no-focus`) Closes angular#8691.
* Refactors `md-no-focus-style` attribute into the `md-no-focus` class. * Adds support for `md-no-focus` class forwarding for the list item. * Add documentation for `md-menu` as proxy item * Enhance tests for `md-menu` inside of `md-list-item` BREAKING CHANGE: `md-no-focus-style` attribute on `md-button` is now a class (`.md-no-focus`) Closes angular#8691.
Actual behavior:
The md-list-item aswell as the md-card generate an internal button without the mdNoFocusStyle
CodePen or Steps to reproduce the issue: *
https://material.angularjs.org/latest/demo/list
Thoughts:
After this would be a bigger task, the question is, if it would be possible/better to add the posibility to disable the mdNoFocusStyle globally for all buttons.
I wrote a simple code for this:
in .config ->
$provide.constant('$MD_DISABLE_FOCUS_STYLE', '');
Also this would enable a performance improvement for Internet Explorer (specially on mobile versions aswell).
The problem is:
$timeout(func,timeout,false)
)Angular Versions: *
Additional Information:
The text was updated successfully, but these errors were encountered: