This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
feat(autocomplete): allow developers to specify amount of dropdown items #9307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ems. * Adds an attribute, which allows developer to overwrite the amount of items shown in the autocomplete dropdown. - When the dropdown doesn't fit into the possible space it will shrink accordingly (as same as before) - When the specified amount of items is higher than the current matches then it will shrink (as same as before) * Fixes the item height deviations between CSS and JavaScript. * Removed the unnecessary CSS for the dropdown height, because everything will be handled from the JS (same as before) * Added tests for the dropdown height calculation, which make sure that everything is now calculated properly. Fixes angular#9306. Closes angular#8751.
devversion
force-pushed
the
feat/autocomplete-dropdown-items
branch
from
6f92a11
to
b107ee8
Compare
|
@ThomasBurleson - Ping for review |
ThomasBurleson
added
needs: presubmit
and removed
needs: review
|
@ThomasBurleson This has passed presubmit, is it ready to merge? Still has "needs review" label. |
topherfangio
added
pr: merge ready
|
@kara Apologies, I was in the process of doing a visual review and got side-tracked. LGTM 👍 |
|
@topherfangio No worries! Just didn't want to jump the gun. |
Frank3K
pushed a commit
to Frank3K/material
that referenced
this pull request
Sep 11, 2016
…ems. (angular#9307) * Adds an attribute, which allows developer to overwrite the amount of items shown in the autocomplete dropdown. - When the dropdown doesn't fit into the possible space it will shrink accordingly (as same as before) - When the specified amount of items is higher than the current matches then it will shrink (as same as before) * Fixes the item height deviations between CSS and JavaScript. * Removed the unnecessary CSS for the dropdown height, because everything will be handled from the JS (same as before) * Added tests for the dropdown height calculation, which make sure that everything is now calculated properly. Fixes angular#9306. Closes angular#8751.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9306. Closes #8751.