This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
autocomplete: item height inconsistency #9306
Labels
Milestone
Comments
devversion
added a commit
to devversion/material
that referenced
this issue
Aug 14, 2016
…ems. * Adds an attribute, which allows developer to overwrite the amount of items shown in the autocomplete dropdown. - When the dropdown doesn't fit into the possible space it will shrink accordingly (as same as before) - When the specified amount of items is higher than the current matches then it will shrink (as same as before) * Fixes the item height deviations between CSS and JavaScript. * Removed the unnecessary CSS for the dropdown height, because everything will be handled from the JS (same as before) * Added tests for the dropdown height calculation, which make sure that everything is now calculated properly. Fixes angular#9306. Closes angular#8751.
devversion
added
the
has: Pull Request
A PR has been created to address this issue
label
Aug 14, 2016
devversion
added a commit
to devversion/material
that referenced
this issue
Sep 4, 2016
…ems. * Adds an attribute, which allows developer to overwrite the amount of items shown in the autocomplete dropdown. - When the dropdown doesn't fit into the possible space it will shrink accordingly (as same as before) - When the specified amount of items is higher than the current matches then it will shrink (as same as before) * Fixes the item height deviations between CSS and JavaScript. * Removed the unnecessary CSS for the dropdown height, because everything will be handled from the JS (same as before) * Added tests for the dropdown height calculation, which make sure that everything is now calculated properly. Fixes angular#9306. Closes angular#8751.
kara
pushed a commit
that referenced
this issue
Sep 8, 2016
…ems. (#9307) * Adds an attribute, which allows developer to overwrite the amount of items shown in the autocomplete dropdown. - When the dropdown doesn't fit into the possible space it will shrink accordingly (as same as before) - When the specified amount of items is higher than the current matches then it will shrink (as same as before) * Fixes the item height deviations between CSS and JavaScript. * Removed the unnecessary CSS for the dropdown height, because everything will be handled from the JS (same as before) * Added tests for the dropdown height calculation, which make sure that everything is now calculated properly. Fixes #9306. Closes #8751.
Frank3K
pushed a commit
to Frank3K/material
that referenced
this issue
Sep 11, 2016
…ems. (angular#9307) * Adds an attribute, which allows developer to overwrite the amount of items shown in the autocomplete dropdown. - When the dropdown doesn't fit into the possible space it will shrink accordingly (as same as before) - When the specified amount of items is higher than the current matches then it will shrink (as same as before) * Fixes the item height deviations between CSS and JavaScript. * Removed the unnecessary CSS for the dropdown height, because everything will be handled from the JS (same as before) * Added tests for the dropdown height calculation, which make sure that everything is now calculated properly. Fixes angular#9306. Closes angular#8751.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
It seems like the SCSS and JS of the
md-autocomplete
have some different values for the item height.48px
41px
This deviation causes the autocomplete to not show the correct amount of items, which is specified in the CSS and JS (
5.5
by default)Also this introduces some small scrollbars, when there are less items.
The text was updated successfully, but these errors were encountered: