Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

autocomplete: item height inconsistency #9306

Closed
devversion opened this issue Aug 14, 2016 · 0 comments
Closed

autocomplete: item height inconsistency #9306

devversion opened this issue Aug 14, 2016 · 0 comments
Assignees
Labels
has: Pull Request A PR has been created to address this issue type: bug
Milestone

Comments

@devversion
Copy link
Member

devversion commented Aug 14, 2016

It seems like the SCSS and JS of the md-autocomplete have some different values for the item height.

CSS JavaScript
48px 41px

This deviation causes the autocomplete to not show the correct amount of items, which is specified in the CSS and JS (5.5 by default)

Also this introduces some small scrollbars, when there are less items.

The 5.5 items is not an even number and should be actually 5x.
I'm assuming the 5.5 was introduced to correct the deviation.

@devversion devversion self-assigned this Aug 14, 2016
devversion added a commit to devversion/material that referenced this issue Aug 14, 2016
…ems.

* Adds an attribute, which allows developer to overwrite the amount of items shown in the autocomplete dropdown.
  - When the dropdown doesn't fit into the possible space it will shrink accordingly (as same as before)
  - When the specified amount of items is higher than the current matches then it will shrink (as same as before)

* Fixes the item height deviations between CSS and JavaScript.
* Removed the unnecessary CSS for the dropdown height, because everything will be handled from the JS (same as before)
* Added tests for the dropdown height calculation, which make sure that everything is now calculated properly.

Fixes angular#9306. Closes angular#8751.
@devversion devversion added the has: Pull Request A PR has been created to address this issue label Aug 14, 2016
@ThomasBurleson ThomasBurleson added this to the 1.1.2 milestone Aug 22, 2016
devversion added a commit to devversion/material that referenced this issue Sep 4, 2016
…ems.

* Adds an attribute, which allows developer to overwrite the amount of items shown in the autocomplete dropdown.
  - When the dropdown doesn't fit into the possible space it will shrink accordingly (as same as before)
  - When the specified amount of items is higher than the current matches then it will shrink (as same as before)

* Fixes the item height deviations between CSS and JavaScript.
* Removed the unnecessary CSS for the dropdown height, because everything will be handled from the JS (same as before)
* Added tests for the dropdown height calculation, which make sure that everything is now calculated properly.

Fixes angular#9306. Closes angular#8751.
@kara kara closed this as completed in #9307 Sep 8, 2016
kara pushed a commit that referenced this issue Sep 8, 2016
…ems. (#9307)

* Adds an attribute, which allows developer to overwrite the amount of items shown in the autocomplete dropdown.
  - When the dropdown doesn't fit into the possible space it will shrink accordingly (as same as before)
  - When the specified amount of items is higher than the current matches then it will shrink (as same as before)

* Fixes the item height deviations between CSS and JavaScript.
* Removed the unnecessary CSS for the dropdown height, because everything will be handled from the JS (same as before)
* Added tests for the dropdown height calculation, which make sure that everything is now calculated properly.

Fixes #9306. Closes #8751.
Frank3K pushed a commit to Frank3K/material that referenced this issue Sep 11, 2016
…ems. (angular#9307)

* Adds an attribute, which allows developer to overwrite the amount of items shown in the autocomplete dropdown.
  - When the dropdown doesn't fit into the possible space it will shrink accordingly (as same as before)
  - When the specified amount of items is higher than the current matches then it will shrink (as same as before)

* Fixes the item height deviations between CSS and JavaScript.
* Removed the unnecessary CSS for the dropdown height, because everything will be handled from the JS (same as before)
* Added tests for the dropdown height calculation, which make sure that everything is now calculated properly.

Fixes angular#9306. Closes angular#8751.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has: Pull Request A PR has been created to address this issue type: bug
Projects
None yet
Development

No branches or pull requests

2 participants