-
Notifications
You must be signed in to change notification settings - Fork 3.4k
docs: improve browser support documentation #9396
Comments
I think that is a reasonable issue. @ThomasBurleson what are your thoughts on this? |
An update from the meeting: The image in README should have visible red boxes with IE 9 & 10. Also, IMO we should have sth like that on the site. Not all library users will visit GitHub & read the README. For comparison, this is the Angular 2 browser compat site: |
Another problem with what's currently in README is that it only shows you a snapshot of the state when this screenshot was taken and not what the general strategy is. For example, does the library only support the latest version of each browser, two latest? Or maybe Chrome is treated differently as Chrome 49 exists in the image? What about Safari? Is 9.1 still supported as shown in the image or is only the latest version supported (as the screenshot was taken when Safari 9.1 was the latest stable version and the only stable one marked in red)? This is all very unclear, an explicit list like the one in Angular 2 docs would be better. |
We improved upon this a little bit in the README in #11083, but I agree that more needs to be done. I also agree that we need to get something clear into the docs site that states what the browser support is. |
TODOs
|
Here's our current autoprefixer config: 'last 2 versions',
'not ie <= 10',
'not ie_mob <= 10',
'last 4 Android versions',
'Safari >= 8' |
I think it'd be useful to make sure the Autoprefixer config and the docs around what browsers are supported stayed in sync somehow - either enforced or via convention, e.g. by putting comments in all places reminding people modifying one place to make sure relevant changes are reflected in others. Perhaps that could be made a 5th item on the TODO list. |
I think that it makes sense to link to / embed this config in the README. I am not sure that it would be appropriate in the docs site. We should probably look at moving it out of https://github.com/angular/material/blob/v1.1.9/scripts/gulp-utils.js#L308-L317 and putting it in a |
Angular Material moved off of
|
I don't think that we can continue to support As mentioned in #10345 (comment), even supporting the Angular seems to specifically support the "2 most recent major versions" which currently aligns with this I'm going to play with http://browserl.ist a bit more to try and come up with a reasonable config. |
But then looking at the autoprefixer default, this seems like an even better configuration: Current settings
Autoprefixer default
In order to work around a bug in browserslist (browserslist/browserslist#266), we'll need to use the following equivalent configuration:
|
In order to compare this new proposed AngularJS Material browser support with Angular Material's browser support, these two links can be used:
|
I agree with your findings. Specifying "last 2 versions" with no percentage (or "not dead") restriction adds unneded dead browsers to the query. OTH, Firefox ESR seems a worthy addition as it may be used in some corporate environments. |
use recommended configuration for autoprefix and browserslist use a more accurate screenshot of browser support update README with link to browserslist settings in package.json update README with link to browserl.ist page that shows our config add browser support info to AngularJS Material home page Fixes #9396
use recommended configuration for autoprefix and browserslist use a more accurate screenshot of browser support update README with link to browserslist settings in package.json update README with link to browserl.ist page that shows our config add browser support info to AngularJS Material home page Fixes #9396
use recommended configuration for autoprefix and browserslist use a more accurate screenshot of browser support update README with link to browserslist settings in package.json update README with link to browserl.ist page that shows our config add browser support info to AngularJS Material home page Fixes #9396
Actual Behavior:
What is the issue? *
README says: "Angular Material is targeted for all browsers with versions n-1; where n is the current browser version."What is the expected behavior?
It should spell out supported IE versions explicitly. It's not clear what "n-1 where n is the current browser version" means with respect to IE as IE, while version 11 still receives security fixes, is not developed anymore and has been succeeded by Microsoft Edge. This sentence could both be understood as that IE 10+ is supported (as current IE is 11) or as if no IE was supported (since IE has been superseded by Edge and last 2 Edge versions are 13 and 14). I also think it'd be better to spell out concrete browser versions that this project supports; otherwise someone can find a niche browser (like Konqueror with the KHTML engine) and complain we don't support it's latest or previous version.The text was updated successfully, but these errors were encountered: