-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix(autocomplete): properly run animation for dialog in demo. #9437
Conversation
@devversion - the However, we should not hide the template... instead the developer can use ng-cloak on the content. |
45824f4
to
3409ff2
Compare
@ThomasBurleson - There is actually not explicit use of the Layout engine here, but anyways I added it as same as we did with the following commits. I did not create an extra wrapper element for it, because it makes the demo source look more difficult than it needs to be.. |
@@ -9,7 +10,7 @@ | |||
</div> | |||
</md-toolbar> | |||
|
|||
<md-dialog-content> | |||
<md-dialog-content ng-cloak> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the ng-cloak
is only useful on the <md-dialog-content>
wrapper. All others are superfluous.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't understand why we even need ngCloak here - I will remove those though..
And just for undstanding, the dialog actions and toolbar are also components which can depend on the Flexbox Engine? Why do we need this on the content only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cloak hides the UI [at initialization] while more complex FlexBox layouts adjust and resize. The toolbar and actions are very simple and IMO do not require the hide trick. But if you want to be consistent, keep all three (3).
* The autocomplete demo with the dialog currently logs a warning for the `ng-cloak` being present on the dialog template. Removing `ng-cloak` removes that warning and also fixes the warning in the console.
3409ff2
to
db8d4ab
Compare
The autocomplete demo with the dialog currently logs a warning for the
ng-cloak
being present on the dialog template.Removing
ng-cloak
removes that warning and also fixes the warning in the console.