This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
feat(navBar): add disabled attribute #10202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
reviewed
Jan 3, 2017
| @@ -28,5 +32,8 @@ | |||
|
|
|||
| <md-checkbox ng-model="disableInkBar">Disable Ink Bar</md-checkbox> | |||
|
|
|||
| <md-checkbox ng-model="secondTabDisabled" aria-label="Disable item two?" style="margin: 5px;"> | |||
| Disable Second Tab? | |||
There was a problem hiding this comment.
I think it would look better to remove the ? here (also in the aria-label)
| @@ -442,6 +444,7 @@ function MdNavItem($$rAF) { | |||
| 'mdNavSref': '@?', | |||
| 'srefOpts': '=?', | |||
| 'name': '@', | |||
| 'disabled': '@?' | |||
There was a problem hiding this comment.
Why is this necessary, if we already use the attrs.$observe?
There was a problem hiding this comment.
Yeah, you're right. It isn't necessary.
kara
added
pr: merge ready
|
@maxjoehnk Can you rebase? |
|
@kara Done |
devversion
added
needs: presubmit
and removed
needs: rebase
* Add disabled attribute to navitem * Update demo to showcase ng-disabled and disabled usage * Add tests * Ignore navbar specific button styling when disabled fixes #9667
mmalerba
added
needs: rebase
|
@maxjoehnk - something bad happened with your rebase. We now have 40 files to merge. That will not be allowed. Please resubmit a new PR based on the lastest from https://github.com/angular/material |
This was referenced Nov 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9667