Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

feat(datepicker,calendar): md-date-filter disables months in month mode #11526

Merged
merged 1 commit into from Jan 7, 2019

Conversation

Splaktar
Copy link
Member

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Using md-date-filter with md-mode="month" results in unexpected results as none of the months are disabled when md-date-filter returns false.

Issue Number:
Closes #11525

What is the new behavior?

md-date-filter is checked and can disable months in month mode if it returns false
added demo
only the first day of the month is checked to disable the month
fix typos in docs
fix JSDoc

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

only the first day of the month is checked to disable the month
fix typos in docs
fix JSDoc

Closes #11525
@Splaktar Splaktar added type: enhancement P3: important Important issues that really should be fixed when possible. labels Nov 27, 2018
@Splaktar Splaktar added this to the 1.1.12 milestone Nov 27, 2018
@Splaktar Splaktar self-assigned this Nov 27, 2018
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Nov 27, 2018
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Nov 27, 2018
@Splaktar Splaktar assigned jelbourn and mmalerba and unassigned jelbourn Dec 20, 2018
@Splaktar Splaktar modified the milestones: 1.1.12, 1.1.13 Jan 3, 2019
@mmalerba mmalerba merged commit 8aa5d58 into master Jan 7, 2019
@Splaktar Splaktar deleted the datepicker-dateFilterForYearView branch January 7, 2019 20:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P3: important Important issues that really should be fixed when possible. pr: merge ready This PR is ready for a caretaker to review type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datepicker: filter only affects validation in month mode
4 participants