Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

fix(datepicker): ISO 8601 dates decorated as invalid in forms #12115

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

Splaktar
Copy link
Member

@Splaktar Splaktar commented Jul 5, 2021

AngularJS Material is in LTS mode

We are no longer accepting changes that are not critical bug fixes into this project.
See Long Term Support for more detail.

PR Checklist

Please check your PR fulfills the following requirements:

  • Does this PR fix a regression since 1.2.0, a security flaw, or a problem caused by a new browser version?
  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

  • valid ISO 8601 dates are decorated as invalid in forms

Fixes #12075

What is the new behavior?

  • when in updateErrorState(), we make sure that ISO 8601 strings are parsed to dates
  • valid ISO 8601 dates are decorated as valid in forms

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

- when in `updateErrorState()`, need to make sure that ISO 8601 strings are
  parsed to dates

Fixes #12075
@google-cla google-cla bot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jul 5, 2021
@Splaktar Splaktar self-assigned this Jul 5, 2021
@Splaktar Splaktar added P2: required Issues that must be fixed. severity: regression This issue is related to a regression labels Jul 5, 2021
@Splaktar Splaktar added this to the 1.2.3 milestone Jul 5, 2021
@Splaktar Splaktar added the pr: merge ready This PR is ready for a caretaker to review label Jul 8, 2021
@Splaktar Splaktar added the pr: lgtm This PR has been approved by the reviewer label Jul 8, 2021
@Splaktar Splaktar merged commit 0a06f99 into master Jul 8, 2021
@Splaktar Splaktar deleted the datepicker-invalid-for-string-dates branch July 8, 2021 17:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P2: required Issues that must be fixed. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review severity: regression This issue is related to a regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

datepicker: invalid value on first load from string
2 participants