Allow focus on contentEditable fields

[barryvdh]

Fixes #5937

Not sure if this is cross-browser, tested etc, but does seem to fix the issue for Android/iOS

[barryvdh]

Any updates on this?

[EladBezalel]

@barryvdh is this still happening on head?

[barryvdh]

Yes, see http://codepen.io/barryvdh/full/VaXyVW/
On desktop: you can edit/type both paragraphs.
On mobile (Android, Chrome browser): You can change the text by selecting/just typing, but you can't just click to see a cursor and start editing. Textarea works as expected.

[barryvdh]

So this is not a good way to fix it or ..?

[ThomasBurleson]

This issue is closed as part of our ‘Surge Focus on Material 2' efforts.
For details, see our forum posting @ http://bit.ly/1UhZyWs.

[barryvdh]

Yes but you did reopen the issue: #5937
Or does that mean it will only be fixed in v2?

[devversion]

@barryvdh Yeah, I reopened #5937. Please add a test for your change and I'll reopen. (Please ping me, once you've finished)

[barryvdh]

Sorry, I looked but I have no idea how to write a test for this. I was looking in https://github.com/angular/material/blob/master/src/core/services/gesture/gesture.spec.js to see what to add/modify, but can't really find a test for the current behavior.
Could you point me in the right direction where the tests are for the current behaviour? (eg. just skipping hijack for input/textarea etc)

[devversion]

@barryvdh I'm sorry, I led you into the wrong direction. I just realized that this is test will require an iOS or Android environment, so tests will always pass.

[devversion]

@ThomasBurleson This is a reasonable PR and looks good to me.

[barryvdh]

@devversion Ok thanks! I changed the check outside those parentheses, should be a bit more readable. now.

[kpgarrod]

What is happening about this? It seems to be a simple fix but the problem still exists in 1.1.0 and it is causing major issues for production users of my shiny new, just launched application. Is there some way to patch the 1.1.0 code or is there a branch I can use in which this problem is fixed.

[devversion]

@kpgarrod This PR has been merged into master and should be available in v1.1.0.

If you still experience issues it would be good to create a new issue for it.