This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
fix(select): fix set form to pristine if ng-model for multiple select is predefined. #6782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -228,9 +228,10 @@ function SelectDirective($mdSelect, $mdUtil, $mdTheming, $mdAria, $compile, $par | |||
| }); | |||
| } | |||
|
|
|||
| if (formCtrl) { | |||
| if (formCtrl && angular.isDefined(attr.multiple)) { | |||
There was a problem hiding this comment.
So if we are not using multiple, then we never $setPristine()? Is that valid logic?
There was a problem hiding this comment.
Yes that is valid, as you can see in 09bd5a3, we should only set the form to pristine if multiple objects are pre-selected in the ngModel.
I manually tested that too, if there is a predefined value for a single select, we don't need to set the form pristine on initialization.
|
@devversion - for 99% of all PRs, each one will need 1 or more unit tests. Can you provide a unit test to validate and verify these changes? |
|
@ThomasBurleson - Yes, I will add a Unit Test for both cases. |
ThomasBurleson
added
the
needs: unit tests
… is predefined. Bug introduced in 09bd5a3 Fixes angular#6556
devversion
force-pushed
the
fix/select-multiple-pristine
branch
from
e206ea6
to
531bc5c
Compare
|
@ThomasBurleson - Added two tests for the |
ThomasBurleson
added
needs: review
ThomasBurleson
added
pr: merge ready
ErinCoughlan
pushed a commit
to ErinCoughlan/material
that referenced
this pull request
Feb 9, 2016
… is predefined. Bug introduced in 09bd5a3 Fixes angular#6556 Closes angular#6782 #breaking
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug introduced in 09bd5a3
Fixes #6556