This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
Fix sidenav not allowing flex children #737
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLAs look good, thanks! |
|
LGTM, thanks. |
ajoslin
pushed a commit
that referenced
this pull request
Nov 24, 2014
|
Merged! Additionally added |
|
Cool that will get rid of an extra |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #734 which prevented you from aligning items to the bottom of a side nav because "flex" wouldn't work on child elements. The
display:flexon.md-closed-addand.md-closed-removealso prevents you from seeing a pop from elements when you open/close the sidenav when you usedisplay:flexon the open state.