This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
refactor: Revert CSS privatization. #8874
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran a grep and found a few you've missed I just wanted to play with grep :-P I'm going to try my hand at a regex for this Actually |
|
@clshortfuse Thanks for the printout. Most of those are actually legitimate though. I only reverted the ones that we changed after the 1.0 release. Some (especially the panel/navbar) were private classes that will be added in 1.1.0, but weren't available in 1.0.0, so I left them as-is. Additionally, there were two classes that I think definitely should be private as they are for use by the internal workings of the FAB speed dial, so I left them. That said, it looks like I did miss a few with the chips and the chip remove container, so I'm working to fix those. Incidentally, that's why the build is failing, but I need to touch base with @devversion about one of the changes real fast before I can fix it. @ThomasBurleson I'm marking this as "Needs Work", but I should have it fixed/ready early tomorrow. |
topherfangio
added
needs: work
and removed
needs: review
topherfangio
force-pushed
the
revert-private-css
branch
from
57409a1
to
c840c1b
Compare
topherfangio
added
needs: review
|
@ThomasBurleson I fixed the failing tests; this should now be ready for review. |
|
@topherfangio - LGTM. Merging on July 11.
|
Revert previous changes to privatize much of our CSS. > See public announcement [**Revisiting the decision to rename private CSS classes in 1.1**](https://groups.google.com/forum/#!msg/ngmaterial/mLJrRW9qrLA/C_Ni3LSrBQAJ) Also fixes an erroneously passing chips test.
topherfangio
force-pushed
the
revert-private-css
branch
from
c840c1b
to
9708c04
Compare
|
Hi @topherfangio , Do you have a list of all css classes which were reverted from private to public? Thanks, |
|
@david-gang - I do not understand "we already changed all classes". Which classes? Do you mean you were overriding private CSS and when those were privatized you added If yes, then you have obviated the entire point of private CSS... as those are classes and styles you should NOT be extending or overriding. |
|
Yes @ThomasBurleson but at the time I used them they were not private, so I relied on them and now that they are public again I can use them again, so I just need a list of all css variables where the privatization was reverted |
|
@david-gang - regardless of our removal of the "_" prefix, I would recommend that you should not use these classes unless you absolutely need to.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert previous changes to privatize much of our CSS.
Also fixes an erroneously passing chips test.