refactor(form-field): remove 6.0.0 deletion targets #10164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mmalerba
reviewed
Feb 26, 2018
| @deletion-target 6.0.0 | ||
| --> | ||
| <span class="mat-form-field-label-wrapper mat-input-placeholder-wrapper mat-form-field-placeholder-wrapper"> | ||
| <span class="mat-form-field-label-wrapper"> |
There was a problem hiding this comment.
Can you add a @deletion-target while you're here to remove all of the mat-input-* classes? We can do the actual remove in a different PR because I know for sure it's going to be a nightmare to merge
There was a problem hiding this comment.
Done. I've set it to 7.0.0, but I can bump it down to 6.0.0 if you want.
crisbeto
force-pushed
the
form-field-6.0.0-deletion-targets
branch
from
14a0de5
to
a6384f3
Compare
|
Can you change the breaking notes to match that earlier PR where applicable (i.e. "Xxx, which was deprecated in 5.0.0, has been removed. Use yyy instead")? |
crisbeto
force-pushed
the
form-field-6.0.0-deletion-targets
branch
from
a6384f3
to
049918e
Compare
|
Done. |
jelbourn
added
pr: lgtm
action: merge
|
Caretaker note: we need to remove google usages of the old API. This might require a cleanup before syncing this PR. |
crisbeto
force-pushed
the
form-field-6.0.0-deletion-targets
branch
from
049918e
to
119f082
Compare
This was referenced Mar 6, 2018
mmalerba
added a commit
to mmalerba/components
that referenced
this pull request
Mar 9, 2018
small piece of angular#10164, split out for presubmit reasons BREAKING CHANGES: - dividerColor which was deprecated in 5.0.0 has been removed. Use color instead. - floatPlaceholder which was deprecated in 5.0.0 has been removed. Use floatLabel instead.
Removes the targets marked for 6.0.0 deletion from the `material/form-field`. BREAKING CHANGES: * `dividerColor` which was deprecated in 5.0.0 has been removed. Use `color` instead. * `floatPlaceholder` which was deprecated in 5.0.0 has been removed. Use `floatLabel` instead. * `MatFormFieldControl.shouldPlaceholderFloat` which was deprecated in 5.0.0 has been removed. Use `shouldLabelFloat` instead. * `FloatPlaceholderType` which was deprecated in 5.0.0 has been removed. Use `FloatLabelType` instead. * `PlaceholderOptions` which was deprecated in 5.0.0 has been removed. Use `LabelOptions` instead. * `MAT_PLACEHOLDER_GLOBAL_OPTIONS` which was deprecated in 5.0.0 has been removed. Use `MAT_LABEL_GLOBAL_OPTIONS` instead. * The `mat-input-placeholder-wrapper` and `mat-form-field-placeholder-wrapper` CSS classes which were deprecated in 5.0.0 have bee removed. The same element can be targeted using the `mat-form-field-label-wrapper` class. * The `mat-input-placeholder` and `mat-form-field-placeholder` CSS classes which were deprecated in 5.0.0 have bee removed. The same element can be targeted using the `mat-form-field-label` class.
crisbeto
force-pushed
the
form-field-6.0.0-deletion-targets
branch
from
119f082
to
98a7d90
Compare
mmalerba
added a commit
that referenced
this pull request
Mar 13, 2018
small piece of #10164, split out for presubmit reasons BREAKING CHANGES: - dividerColor which was deprecated in 5.0.0 has been removed. Use color instead. - floatPlaceholder which was deprecated in 5.0.0 has been removed. Use floatLabel instead.
|
closing since all shard PRs have been merged |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the targets marked for 6.0.0 deletion from the
material/form-field.BREAKING CHANGES:
dividerColorwhich was deprecated in 5.0.0 has been removed. Usecolorinstead.floatPlaceholderwhich was deprecated in 5.0.0 has been removed. UsefloatLabelinstead.MatFormFieldControl.shouldPlaceholderFloatwhich was deprecated in 5.0.0 has been removed. UseshouldLabelFloatinstead.FloatPlaceholderTypewhich was deprecated in 5.0.0 has been removed. UseFloatLabelTypeinstead.PlaceholderOptionswhich was deprecated in 5.0.0 has been removed. UseLabelOptionsinstead.MAT_PLACEHOLDER_GLOBAL_OPTIONSwhich was deprecated in 5.0.0 has been removed. UseMAT_LABEL_GLOBAL_OPTIONSinstead.mat-input-placeholder-wrapperandmat-form-field-placeholder-wrapperCSS classes which were deprecated in 5.0.0 have bee removed. The same element can be targeted using themat-form-field-label-wrapperclass.mat-input-placeholderandmat-form-field-placeholderCSS classes which were deprecated in 5.0.0 have bee removed. The same element can be targeted using themat-form-field-labelclass.