Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(snack-bar): remove 6.0.0 deletion targets #10253

Merged
merged 1 commit into from
Mar 9, 2018
Merged

refactor(snack-bar): remove 6.0.0 deletion targets #10253

merged 1 commit into from
Mar 9, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 3, 2018

Removes the targets marked for deletion in 6.0.0 inside the material/snack-bar entry point.

BREAKING CHANGES:

  • extraClasses which was deprecated in 5.0.0 has been removed. Use panelClass instead.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 3, 2018
jelbourn
jelbourn approved these changes Mar 5, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release and removed pr: needs review labels Mar 5, 2018
@jelbourn
Copy link
Member

jelbourn commented Mar 5, 2018

Caretaker note: may need internal removal first

@googlebot googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Mar 8, 2018
@josephperrott josephperrott added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Mar 8, 2018
@crisbeto
refactor(snack-bar): remove 6.0.0 deletion targets
36fcec3 
Removes the targets marked for deletion in 6.0.0 inside the `material/snack-bar` entry point.

BREAKING CHANGES:
* `extraClasses` which was deprecated in 5.0.0 has been removed. Use `panelClass` instead.
@crisbeto crisbeto force-pushed the snack-bar-6.0.0-deletion-targets branch from 91f485a to 36fcec3 Compare March 8, 2018 17:03
@angular angular deleted a comment from googlebot Mar 8, 2018
@jelbourn jelbourn merged commit 88bb6f3 into angular:master Mar 9, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@josephperrott josephperrott Awaiting requested review from josephperrott

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @googlebot @josephperrott