Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(menu): not updating panel direction after init #11070

Merged
merged 1 commit into from
May 1, 2018
Merged

fix(menu): not updating panel direction after init #11070

merged 1 commit into from
May 1, 2018

Conversation

crisbeto
Copy link
Member

Handles the case where the menu trigger's direction has been updated after its overlay has been initialized.

@crisbeto
fix(menu): not updating panel direction after init
b9a25ee 
Handles the case where the menu trigger's direction has been updated after its overlay has been initialized.
@crisbeto crisbeto requested a review from kara as a code owner April 30, 2018 10:18
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 30, 2018
jelbourn
jelbourn approved these changes Apr 30, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs review labels Apr 30, 2018
@josephperrott josephperrott removed the request for review from kara May 1, 2018 14:35
@josephperrott josephperrott merged commit 294ba3c into angular:master May 1, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @googlebot @josephperrott