Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sort] Array is ugly with opacity #11340

Closed
andrewseguin opened this issue May 15, 2018 · 1 comment · Fixed by #11533
Closed

[Sort] Array is ugly with opacity #11340

andrewseguin opened this issue May 15, 2018 · 1 comment · Fixed by #11533
Assignees
@crisbeto @andrewseguin

Comments

@andrewseguin
Copy link
Contributor

andrewseguin commented May 15, 2018 •
edited
Loading

sort-arrow

The sort header's color is set as an RGBA value: rgba(0,0,0,.54)

This causes the arrow's parts to have a transparency applied. Would be better in this case to have a color applied with an opaque value.

https://stackblitz.com/edit/angular-ac6kex?file=app/table-sorting-example.css
@andrewseguin andrewseguin added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label May 15, 2018
@andrewseguin andrewseguin self-assigned this May 15, 2018
@crisbeto crisbeto self-assigned this May 27, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue May 27, 2018
@crisbeto
fix(table): use solid color for sorting arrow
a00ba9e 
Currently we use an rgba color for the table's sorting arrow which ends up looking weird, because the arrow is made up of multiple stacked elements. These changes add some logic that convert the arrow's color into a solid one so the individual pieces can blend into each other.

Fixes angular#11340.
@crisbeto crisbeto mentioned this issue May 27, 2018
Merged
josephperrott pushed a commit that referenced this issue May 30, 2018
@crisbeto @josephperrott
fix(table): use solid color for sorting arrow
270643e 
Currently we use an rgba color for the table's sorting arrow which ends up looking weird, because the arrow is made up of multiple stacked elements. These changes add some logic that convert the arrow's color into a solid one so the individual pieces can blend into each other.

Fixes #11340.
andrewseguin pushed a commit that referenced this issue Jun 5, 2018
@crisbeto @andrewseguin
fix(table): use solid color for sorting arrow
07457c9 
Currently we use an rgba color for the table's sorting arrow which ends up looking weird, because the arrow is made up of multiple stacked elements. These changes add some logic that convert the arrow's color into a solid one so the individual pieces can blend into each other.

Fixes #11340.
andrewseguin pushed a commit that referenced this issue Jun 7, 2018
@crisbeto @andrewseguin
fix(table): use solid color for sorting arrow
b416a6d 
Currently we use an rgba color for the table's sorting arrow which ends up looking weird, because the arrow is made up of multiple stacked elements. These changes add some logic that convert the arrow's color into a solid one so the individual pieces can blend into each other.

Fixes #11340.
tinayuangao pushed a commit that referenced this issue Jun 20, 2018
@crisbeto @tinayuangao
fix(table): use solid color for sorting arrow (#11533)
4b13555 
Currently we use an rgba color for the table's sorting arrow which ends up looking weird, because the arrow is made up of multiple stacked elements. These changes add some logic that convert the arrow's color into a solid one so the individual pieces can blend into each other.

Fixes #11340.
tinayuangao pushed a commit that referenced this issue Jun 20, 2018
@crisbeto @tinayuangao
fix(table): use solid color for sorting arrow (#11533)
d083d76 
Currently we use an rgba color for the table's sorting arrow which ends up looking weird, because the arrow is made up of multiple stacked elements. These changes add some logic that convert the arrow's color into a solid one so the individual pieces can blend into each other.

Fixes #11340.
victoriaaa234 pushed a commit that referenced this issue Jul 25, 2018
@crisbeto @victoriaaa234
fix(table): use solid color for sorting arrow (#11533)
3b80228 
Currently we use an rgba color for the table's sorting arrow which ends up looking weird, because the arrow is made up of multiple stacked elements. These changes add some logic that convert the arrow's color into a solid one so the individual pieces can blend into each other.

Fixes #11340.
@andrewseguin andrewseguin added has pr and removed has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels May 7, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

@andrewseguin andrewseguin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(table): use solid color for sorting arrow crisbeto/material2
2 participants
@crisbeto @andrewseguin