Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add disabled styling for unchecked pseudo checkbox #15405

Merged
merged 1 commit into from
Mar 20, 2019
Merged

fix: add disabled styling for unchecked pseudo checkbox #15405

merged 1 commit into from
Mar 20, 2019

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 6, 2019

Currently we have some disabled styling for the pseudo checkbox, but it only applies to checked checkboxes. These changes add some styling to distinguish unchecked disabled checkboxes.

@crisbeto
fix: add disabled styling for unchecked pseudo checkbox
18afddb 
Currently we have some disabled styling for the pseudo checkbox, but it only applies to checked checkboxes. These changes add some styling to distinguish unchecked disabled checkboxes.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Mar 6, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner March 6, 2019 21:37
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 6, 2019
josephperrott
josephperrott approved these changes Mar 7, 2019
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 7, 2019
@andrewseguin andrewseguin merged commit 20b140b into angular:master Mar 20, 2019
andrewseguin pushed a commit that referenced this pull request Mar 25, 2019
@crisbeto @andrewseguin
fix: add disabled styling for unchecked pseudo checkbox (#15405)
bd1c973 
Currently we have some disabled styling for the pseudo checkbox, but it only applies to checked checkboxes. These changes add some styling to distinguish unchecked disabled checkboxes.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@josephperrott josephperrott

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @josephperrott @googlebot @andrewseguin