Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schematics: CSS files generated in Angular CLI project using SCSS styles #15502

Closed
Splaktar opened this issue Mar 16, 2019 · 1 comment · Fixed by #15513
Closed

schematics: CSS files generated in Angular CLI project using SCSS styles #15502

Splaktar opened this issue Mar 16, 2019 · 1 comment · Fixed by #15513
Assignees
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@Splaktar
Copy link
Member

What is the expected behavior?

.scss files should be generated

What is the current behavior?

.css files are generated

What are the steps to reproduce?

  • ng new --styles=scss material-demo
    • no routing module
  • ng add @angular/material
    • select Custom theme
    • add hammerjs
    • add animations module
ng g @angular/material:nav 
? What should be the name of the component? nav
CREATE src/app/nav/nav.component.css (193 bytes)
CREATE src/app/nav/nav.component.html (934 bytes)
CREATE src/app/nav/nav.component.spec.ts (1061 bytes)
CREATE src/app/nav/nav.component.ts (544 bytes)
UPDATE src/app/app.module.ts (785 bytes)

It doesn't seem to be picking up the default style extension from the workspace.
angular.json

      "schematics": {
        "@schematics/angular:component": {
          "style": "scss"
        }
      },

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular CLI: 7.3.6
Node: 10.15.3
OS: darwin x64
Angular: 7.2.9
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.13.6
@angular-devkit/build-angular     0.13.6
@angular-devkit/build-optimizer   0.13.6
@angular-devkit/build-webpack     0.13.6
@angular-devkit/core              7.3.6
@angular-devkit/schematics        7.3.6
@angular/cdk                      7.3.4
@angular/cli                      7.3.6
@angular/material                 7.3.4
@ngtools/webpack                  7.3.6
@schematics/angular               7.3.6
@schematics/update                0.13.6
rxjs                              6.3.3
typescript                        3.2.4
webpack                           4.29.0

OS: macOS Mojave

Is there anything else we should know?

This was working in 7.0.0.
@devversion this seems to be related to #15235.

@devversion devversion self-assigned this Mar 16, 2019
devversion added a commit to devversion/material2 that referenced this issue Mar 17, 2019
…espected

With angular/angular-cli@a12a4e0, the CLI made the
option naming consistent. Since the default schematic are therefore named differently, we need to update our logic
to work with the old option name and the new option name.

Fixes angular#15502
devversion added a commit to devversion/material2 that referenced this issue Mar 17, 2019
…espected

With angular/angular-cli@a12a4e0, the CLI made the
option naming consistent. Since the default schematic are therefore named differently, we need to update our logic
to work with the old option name and the new option name.

Fixes angular#15502
devversion added a commit to devversion/material2 that referenced this issue Mar 17, 2019
…espected

With angular/angular-cli@a12a4e0, the CLI made the
option naming consistent. Since the default schematic are therefore named differently, we need to update our logic
to work with the old option name and the new option name.

Fixes angular#15502
devversion added a commit to devversion/material2 that referenced this issue Mar 17, 2019
…espected

With angular/angular-cli@a12a4e0, the CLI made the
option naming consistent. Since the default schematic are therefore named differently, we need to update our logic
to work with the old option name and the new option name.

Fixes angular#15502
@devversion devversion added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent has pr labels Mar 17, 2019
devversion added a commit to devversion/material2 that referenced this issue Mar 20, 2019
…espected

With angular/angular-cli@a12a4e0, the CLI made the
option naming consistent. Since the default schematic are therefore named differently, we need to update our logic
to work with the old option name and the new option name.

Fixes angular#15502
andrewseguin pushed a commit that referenced this issue Mar 22, 2019
…espected (#15513)

With angular/angular-cli@a12a4e0, the CLI made the
option naming consistent. Since the default schematic are therefore named differently, we need to update our logic
to work with the old option name and the new option name.

Fixes #15502
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants