fix(schematics): ensure project "style" and "skipTests" options are respected #15513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
force-pushed
the
fix/schematics-not-working-latest-cli
branch
3 times, most recently
from
2c0c903 to
46863ab
Compare
devversion
added
pr: merge safe
target: patch
|
cc. @Splaktar |
crisbeto
added
pr: lgtm
action: merge
This comment has been minimized.
This comment has been minimized.
alan-agius4
reviewed
Mar 20, 2019
…espected With angular/angular-cli@a12a4e0, the CLI made the option naming consistent. Since the default schematic are therefore named differently, we need to update our logic to work with the old option name and the new option name. Fixes angular#15502
devversion
force-pushed
the
fix/schematics-not-working-latest-cli
branch
from
46863ab to
eff37fe
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With angular/angular-cli@a12a4e0, the CLI made the option naming consistent. Since the
default schematic are therefore named differently, we need to update our logic to
work with the old option name and the new option name.
Fixes #15502