fix(connected-position-strategy): wrong logic when determining whether element is on screen #2677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r element is on screen Fixes some faulty logic, introduced in angular#2102, that meant that the overlay considers the viewport's scroll offset when determining how much it overflows on either side. Fixes angular#2658.
googlebot
added
the
cla: yes
|
Don't you want to account for the scroll? |
|
Nope, this is relative to the viewport, not the page itself. I didn't really notice it testing locally, because our demo app uses |
|
LGTM |
jelbourn
added
pr: lgtm
action: merge
kara
pushed a commit
to kara/material2
that referenced
this pull request
Jan 20, 2017
…r element is on screen (angular#2677) Fixes some faulty logic, introduced in angular#2102, that meant that the overlay considers the viewport's scroll offset when determining how much it overflows on either side. Fixes angular#2658.
This was referenced Jan 25, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some faulty logic, introduced in #2102, that meant that the overlay considers the viewport's scroll offset when determining how much it overflows on either side.
Fixes #2658.