Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): floating label overlapping elements above select #6228

Merged
merged 1 commit into from Aug 2, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 2, 2017

Adds some padding to the top of a select, reserving enough space for the floating label.

Fixes #6171.

@crisbeto crisbeto requested a review from kara as a code owner August 2, 2017 17:36
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 2, 2017
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara removed their assignment Aug 2, 2017
@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Aug 2, 2017
@crisbeto crisbeto removed the action: merge The PR is ready for merge by the caretaker label Aug 2, 2017
Adds some padding to the top of a select, reserving enough space for the floating label.

Fixes angular#6171.
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Aug 2, 2017
@tinayuangao tinayuangao merged commit a780052 into angular:master Aug 2, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MdSelect floating label overlaps above HTML elements
4 participants