Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sort] Add disable input #8622

Closed
Potmos opened this issue Nov 23, 2017 · 1 comment · Fixed by #8643
Closed

[Sort] Add disable input #8622

Potmos opened this issue Nov 23, 2017 · 1 comment · Fixed by #8643
Assignees
@crisbeto
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@Potmos
Copy link

Potmos commented Nov 23, 2017 •
edited
Loading

Bug, feature request, or proposal:

Proposal: Allow the mat-sort-header tag to be attached to a boolean.

What is the expected behavior?

There should be a way to bind a column to a variable so you could enable or disable the the sorting.

What is the current behavior?

If there is the mat-sort-header tag on the column you can't disable the sorting.

What are the steps to reproduce?

https://plnkr.co/edit/SaM2RYwm3i7mRJhOIH2k?p=preview
I wish that clicking the button would disable the sorting.

What is the use-case or motivation for changing an existing behavior?

This would make the sorting more flexible.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

All of them

Is there anything else we should know?
@Potmos Potmos changed the title mat-sort-header mat-sort-header binded to a boolean Nov 23, 2017
@crisbeto crisbeto self-assigned this Nov 25, 2017
@crisbeto crisbeto added feature This issue represents a new feature or feature request rather than a bug or bug fix has pr labels Nov 25, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 25, 2017
@crisbeto
feat(sort): add the ability to disable sort toggling
0845a60 
Adds the ability for a `mat-sort-header` or `mat-sort` instance to be disabled, preventing the user from changing the sorting direction.

Fixes angular#8622.
@crisbeto crisbeto mentioned this issue Nov 25, 2017
Merged
@andrewseguin andrewseguin added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Nov 27, 2017
@andrewseguin andrewseguin changed the title mat-sort-header binded to a boolean [Sort] Add disable input Nov 27, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 27, 2017
@crisbeto
feat(sort): add the ability to disable sort toggling
0c03032 
Adds the ability for a `mat-sort-header` or `mat-sort` instance to be disabled, preventing the user from changing the sorting direction.

Fixes angular#8622.
tinayuangao pushed a commit that referenced this issue Dec 1, 2017
@crisbeto @tinayuangao
feat(sort): add the ability to disable sort toggling (#8643)
7576a73 
Adds the ability for a `mat-sort-header` or `mat-sort` instance to be disabled, preventing the user from changing the sorting direction.

Fixes #8622.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(sort): add the ability to disable sort toggling crisbeto/material2
3 participants
@crisbeto @Potmos @andrewseguin