Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layout): handle platforms that don't support matchMedia #8775

Merged
merged 1 commit into from
Jan 4, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 2, 2017

Adds an extra check to ensure that the current platform supports window.matchMedia.

Fixes #8710.

Adds an extra check to ensure that the current platform supports `window.matchMedia`.

Fixes angular#8710.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 2, 2017
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release target: patch This PR is targeted for the next patch release and removed pr: needs review target: major This PR is targeted for the next major release labels Dec 5, 2017
@andrewseguin andrewseguin added the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Dec 13, 2017
@jelbourn jelbourn merged commit 4846e4c into angular:master Jan 4, 2018
jelbourn pushed a commit to jelbourn/components that referenced this pull request Jan 8, 2018
…8775)

Adds an extra check to ensure that the current platform supports `window.matchMedia`.

Fixes angular#8710.
jelbourn pushed a commit to jelbourn/components that referenced this pull request Jan 9, 2018
…8775)

Adds an extra check to ensure that the current platform supports `window.matchMedia`.

Fixes angular#8710.
jelbourn pushed a commit that referenced this pull request Jan 9, 2018
Adds an extra check to ensure that the current platform supports `window.matchMedia`.

Fixes #8710.
tinayuangao pushed a commit that referenced this pull request Jan 10, 2018
Adds an extra check to ensure that the current platform supports `window.matchMedia`.

Fixes #8710.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property 'bind' of undefined at new MediaMatcher
5 participants