-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix schematics collection JSON. #11839
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Aims at fixing #11836 |
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets keep the aliases for backwards compat for now.
@amcdnl - what is the lowest version of Angular CLI you want to be compatible with? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think it's fine as long as the documentation is still correct |
Add missing quote and remove redundant aliases. Latest Angular CLI releases refuses to generate anything without those changes.
D:\angular5\almni-ng>ng add @angular/material Angular CLI: 6.0.8 Package Version@angular-devkit/architect 0.6.8 D:\angular5\almni-ng> |
@rijomonr - the fix is not yet released. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Add missing quote and remove redundant aliases. Latest Angular CLI
releases refuses to generate anything without those changes.