Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(schematics): valid collection.json #11980

Closed
wants to merge 1 commit into from
Closed

fix(schematics): valid collection.json #11980

wants to merge 1 commit into from

Conversation

cyrilletuzi
Copy link
Contributor

Fixes #11979

@cyrilletuzi cyrilletuzi requested a review from amcdnl as a code owner June 29, 2018 12:06
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 29, 2018
@cyrilletuzi cyrilletuzi mentioned this pull request Jun 29, 2018
Closed
@ngbot
Copy link

ngbot bot commented Jun 29, 2018

Hi @cyrilletuzi! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@josephperrott
Copy link
Member

Thanks for making this PR, I actually just merged in this fix from another PR (#11839) so I am going to close this one.

@cyrilletuzi cyrilletuzi deleted the patch-1 branch June 29, 2018 16:28
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amcdnl amcdnl Awaiting requested review from amcdnl

Assignees
No one assigned
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid collection.json in schematics
3 participants
@cyrilletuzi @josephperrott @googlebot