Skip to content
This repository has been archived by the owner on Oct 29, 2023. It is now read-only.

Commit

Permalink
Remove @nguniversal/* projects
Browse files Browse the repository at this point in the history 
Previously, the `@nguniversal/*` packages were imported into standard
`@angular/cli` apps. However, these packages are not supposed to be used
in Angular apps (on the client) and thus do not need to be processed by
`ngcc`. They contain code that must be run on the server (with access to
Node.js APIs) and thus the corresponding projects were failing during
build, due to missing built-in Node.js modules (e.g. `fs`).

We should definitely test how ngUniversal apps work with Ivy (and
`ngcc`), but this is not the right way. Removing the packages for now.
  • Loading branch information
@gkalpak
gkalpak committed Oct 18, 2019
1 parent 0c22a49 commit 806d424
Show file tree
Hide file tree
Showing 73 changed files with 0 additions and 1,508 deletions.
339 changes: 0 additions & 339 deletions angular.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11077,345 +11077,6 @@
}
}
},
"nguniversalaspnetcore-engine-ngcc": {
"projectType": "application",
"schematics": {},
"root": "projects/nguniversalaspnetcore-engine-ngcc",
"sourceRoot": "projects/nguniversalaspnetcore-engine-ngcc/src",
"prefix": "app",
"architect": {
"build": {
"builder": "@angular-devkit/build-angular:browser",
"options": {
"outputPath": "dist/nguniversalaspnetcore-engine-ngcc",
"index": "projects/nguniversalaspnetcore-engine-ngcc/src/index.html",
"main": "projects/nguniversalaspnetcore-engine-ngcc/src/main.ts",
"polyfills": "projects/nguniversalaspnetcore-engine-ngcc/src/polyfills.ts",
"tsConfig": "projects/nguniversalaspnetcore-engine-ngcc/tsconfig.app.json",
"aot": true,
"assets": [
"projects/nguniversalaspnetcore-engine-ngcc/src/favicon.ico",
"projects/nguniversalaspnetcore-engine-ngcc/src/assets"
],
"styles": [
"projects/nguniversalaspnetcore-engine-ngcc/src/styles.css"
],
"scripts": []
},
"configurations": {
"production": {
"fileReplacements": [
{
"replace": "projects/nguniversalaspnetcore-engine-ngcc/src/environments/environment.ts",
"with": "projects/nguniversalaspnetcore-engine-ngcc/src/environments/environment.prod.ts"
}
],
"optimization": true,
"outputHashing": "all",
"sourceMap": false,
"extractCss": true,
"namedChunks": false,
"aot": true,
"extractLicenses": true,
"vendorChunk": false,
"buildOptimizer": true,
"budgets": [
{
"type": "initial",
"maximumWarning": "2mb",
"maximumError": "5mb"
}
]
}
}
},
"serve": {
"builder": "@angular-devkit/build-angular:dev-server",
"options": {
"browserTarget": "nguniversalaspnetcore-engine-ngcc:build"
},
"configurations": {
"production": {
"browserTarget": "nguniversalaspnetcore-engine-ngcc:build:production"
}
}
},
"extract-i18n": {
"builder": "@angular-devkit/build-angular:extract-i18n",
"options": {
"browserTarget": "nguniversalaspnetcore-engine-ngcc:build"
}
},
"test": {
"builder": "@angular-devkit/build-angular:karma",
"options": {
"main": "projects/nguniversalaspnetcore-engine-ngcc/src/test.ts",
"polyfills": "projects/nguniversalaspnetcore-engine-ngcc/src/polyfills.ts",
"tsConfig": "projects/nguniversalaspnetcore-engine-ngcc/tsconfig.spec.json",
"karmaConfig": "projects/nguniversalaspnetcore-engine-ngcc/karma.conf.js",
"assets": [
"projects/nguniversalaspnetcore-engine-ngcc/src/favicon.ico",
"projects/nguniversalaspnetcore-engine-ngcc/src/assets"
],
"styles": [
"projects/nguniversalaspnetcore-engine-ngcc/src/styles.css"
],
"scripts": []
}
},
"lint": {
"builder": "@angular-devkit/build-angular:tslint",
"options": {
"tsConfig": [
"projects/nguniversalaspnetcore-engine-ngcc/tsconfig.app.json",
"projects/nguniversalaspnetcore-engine-ngcc/tsconfig.spec.json",
"projects/nguniversalaspnetcore-engine-ngcc/e2e/tsconfig.json"
],
"exclude": [
"**/node_modules/**"
]
}
},
"e2e": {
"builder": "@angular-devkit/build-angular:protractor",
"options": {
"protractorConfig": "projects/nguniversalaspnetcore-engine-ngcc/e2e/protractor.conf.js",
"devServerTarget": "nguniversalaspnetcore-engine-ngcc:serve"
},
"configurations": {
"production": {
"devServerTarget": "nguniversalaspnetcore-engine-ngcc:serve:production"
}
}
}
}
},
"nguniversalcommon-ngcc": {
"projectType": "application",
"schematics": {},
"root": "projects/nguniversalcommon-ngcc",
"sourceRoot": "projects/nguniversalcommon-ngcc/src",
"prefix": "app",
"architect": {
"build": {
"builder": "@angular-devkit/build-angular:browser",
"options": {
"outputPath": "dist/nguniversalcommon-ngcc",
"index": "projects/nguniversalcommon-ngcc/src/index.html",
"main": "projects/nguniversalcommon-ngcc/src/main.ts",
"polyfills": "projects/nguniversalcommon-ngcc/src/polyfills.ts",
"tsConfig": "projects/nguniversalcommon-ngcc/tsconfig.app.json",
"aot": true,
"assets": [
"projects/nguniversalcommon-ngcc/src/favicon.ico",
"projects/nguniversalcommon-ngcc/src/assets"
],
"styles": [
"projects/nguniversalcommon-ngcc/src/styles.css"
],
"scripts": []
},
"configurations": {
"production": {
"fileReplacements": [
{
"replace": "projects/nguniversalcommon-ngcc/src/environments/environment.ts",
"with": "projects/nguniversalcommon-ngcc/src/environments/environment.prod.ts"
}
],
"optimization": true,
"outputHashing": "all",
"sourceMap": false,
"extractCss": true,
"namedChunks": false,
"aot": true,
"extractLicenses": true,
"vendorChunk": false,
"buildOptimizer": true,
"budgets": [
{
"type": "initial",
"maximumWarning": "2mb",
"maximumError": "5mb"
}
]
}
}
},
"serve": {
"builder": "@angular-devkit/build-angular:dev-server",
"options": {
"browserTarget": "nguniversalcommon-ngcc:build"
},
"configurations": {
"production": {
"browserTarget": "nguniversalcommon-ngcc:build:production"
}
}
},
"extract-i18n": {
"builder": "@angular-devkit/build-angular:extract-i18n",
"options": {
"browserTarget": "nguniversalcommon-ngcc:build"
}
},
"test": {
"builder": "@angular-devkit/build-angular:karma",
"options": {
"main": "projects/nguniversalcommon-ngcc/src/test.ts",
"polyfills": "projects/nguniversalcommon-ngcc/src/polyfills.ts",
"tsConfig": "projects/nguniversalcommon-ngcc/tsconfig.spec.json",
"karmaConfig": "projects/nguniversalcommon-ngcc/karma.conf.js",
"assets": [
"projects/nguniversalcommon-ngcc/src/favicon.ico",
"projects/nguniversalcommon-ngcc/src/assets"
],
"styles": [
"projects/nguniversalcommon-ngcc/src/styles.css"
],
"scripts": []
}
},
"lint": {
"builder": "@angular-devkit/build-angular:tslint",
"options": {
"tsConfig": [
"projects/nguniversalcommon-ngcc/tsconfig.app.json",
"projects/nguniversalcommon-ngcc/tsconfig.spec.json",
"projects/nguniversalcommon-ngcc/e2e/tsconfig.json"
],
"exclude": [
"**/node_modules/**"
]
}
},
"e2e": {
"builder": "@angular-devkit/build-angular:protractor",
"options": {
"protractorConfig": "projects/nguniversalcommon-ngcc/e2e/protractor.conf.js",
"devServerTarget": "nguniversalcommon-ngcc:serve"
},
"configurations": {
"production": {
"devServerTarget": "nguniversalcommon-ngcc:serve:production"
}
}
}
}
},
"nguniversalexpress-engine-ngcc": {
"projectType": "application",
"schematics": {},
"root": "projects/nguniversalexpress-engine-ngcc",
"sourceRoot": "projects/nguniversalexpress-engine-ngcc/src",
"prefix": "app",
"architect": {
"build": {
"builder": "@angular-devkit/build-angular:browser",
"options": {
"outputPath": "dist/nguniversalexpress-engine-ngcc",
"index": "projects/nguniversalexpress-engine-ngcc/src/index.html",
"main": "projects/nguniversalexpress-engine-ngcc/src/main.ts",
"polyfills": "projects/nguniversalexpress-engine-ngcc/src/polyfills.ts",
"tsConfig": "projects/nguniversalexpress-engine-ngcc/tsconfig.app.json",
"aot": true,
"assets": [
"projects/nguniversalexpress-engine-ngcc/src/favicon.ico",
"projects/nguniversalexpress-engine-ngcc/src/assets"
],
"styles": [
"projects/nguniversalexpress-engine-ngcc/src/styles.css"
],
"scripts": []
},
"configurations": {
"production": {
"fileReplacements": [
{
"replace": "projects/nguniversalexpress-engine-ngcc/src/environments/environment.ts",
"with": "projects/nguniversalexpress-engine-ngcc/src/environments/environment.prod.ts"
}
],
"optimization": true,
"outputHashing": "all",
"sourceMap": false,
"extractCss": true,
"namedChunks": false,
"aot": true,
"extractLicenses": true,
"vendorChunk": false,
"buildOptimizer": true,
"budgets": [
{
"type": "initial",
"maximumWarning": "2mb",
"maximumError": "5mb"
}
]
}
}
},
"serve": {
"builder": "@angular-devkit/build-angular:dev-server",
"options": {
"browserTarget": "nguniversalexpress-engine-ngcc:build"
},
"configurations": {
"production": {
"browserTarget": "nguniversalexpress-engine-ngcc:build:production"
}
}
},
"extract-i18n": {
"builder": "@angular-devkit/build-angular:extract-i18n",
"options": {
"browserTarget": "nguniversalexpress-engine-ngcc:build"
}
},
"test": {
"builder": "@angular-devkit/build-angular:karma",
"options": {
"main": "projects/nguniversalexpress-engine-ngcc/src/test.ts",
"polyfills": "projects/nguniversalexpress-engine-ngcc/src/polyfills.ts",
"tsConfig": "projects/nguniversalexpress-engine-ngcc/tsconfig.spec.json",
"karmaConfig": "projects/nguniversalexpress-engine-ngcc/karma.conf.js",
"assets": [
"projects/nguniversalexpress-engine-ngcc/src/favicon.ico",
"projects/nguniversalexpress-engine-ngcc/src/assets"
],
"styles": [
"projects/nguniversalexpress-engine-ngcc/src/styles.css"
],
"scripts": []
}
},
"lint": {
"builder": "@angular-devkit/build-angular:tslint",
"options": {
"tsConfig": [
"projects/nguniversalexpress-engine-ngcc/tsconfig.app.json",
"projects/nguniversalexpress-engine-ngcc/tsconfig.spec.json",
"projects/nguniversalexpress-engine-ngcc/e2e/tsconfig.json"
],
"exclude": [
"**/node_modules/**"
]
}
},
"e2e": {
"builder": "@angular-devkit/build-angular:protractor",
"options": {
"protractorConfig": "projects/nguniversalexpress-engine-ngcc/e2e/protractor.conf.js",
"devServerTarget": "nguniversalexpress-engine-ngcc:serve"
},
"configurations": {
"production": {
"devServerTarget": "nguniversalexpress-engine-ngcc:serve:production"
}
}
}
}
},
"ngx-bootstrap-ngcc": {
"projectType": "application",
"schematics": {},
Expand Down
2 changes: 0 additions & 2 deletions infra/failing-projects.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,5 @@
"ng2-completer-ngcc",
"ng2-dragula-ngcc",
"ng2-file-upload-ngcc",
"nguniversalaspnetcore-engine-ngcc",
"nguniversalexpress-engine-ngcc",
"ngx-formlymaterial-ngcc"
]
3 changes: 0 additions & 3 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,6 @@
"@ng-idle/core": "8.0.0-beta.4",
"@ng-select/ng-select": "3.1.0",
"@ngui/auto-complete": "2.0.0",
"@nguniversal/aspnetcore-engine": "8.1.1",
"@nguniversal/common": "8.1.1",
"@nguniversal/express-engine": ">=5.0.0",
"@ngx-formly/bootstrap": "5.5.1",
"@ngx-formly/core": "5.5.1",
"@ngx-formly/material": "5.5.1",
Expand Down
12 changes: 0 additions & 12 deletions projects/nguniversalaspnetcore-engine-ngcc/browserslist
View file

This file was deleted.

0 comments on commit 806d424

Please sign in to comment.