Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

some rules issues we found #20

Open
lleitep3 opened this issue Jan 10, 2017 · 0 comments
Open

some rules issues we found #20

lleitep3 opened this issue Jan 10, 2017 · 0 comments

Comments

@lleitep3
Copy link

Hi people,

We are using the plugin and found some rule issues...

We are using:

  • protractor@4.0.14
  • protractor-accessibility-plugin@0.3.0

Our config file is:

chromeA11YDevTools: { treatWarningsAsFailures: true, auditConfiguration: { auditRulesToRun: [ 'ariaOnReservedElement', 'ariaOwnsDescendant', 'ariaRoleNotScoped', 'audioWithoutControls', 'badAriaAttribute', 'badAriaAttributeValue', 'badAriaRole', 'controlsWithoutLabel', 'duplicateId', 'focusableElementNotVisibleAndNotAriaHidden', 'humanLangMissing', 'imagesWithoutAltText', 'linkWithUnclearPurpose', 'mainRoleOnInappropriateElement', 'elementsWithMeaningfulBackgroundImage', 'multipleAriaOwners', 'multipleLabelableElementsPerLabel', 'nonExistentRelatedElement', // 'nonExistentAriaLabelledbyElement', -> is on the docs, but does not exist 'pageWithoutTitle', 'requiredAriaAttributeMissing', 'requiredOwnedAriaRoleMissing', 'roleTooltipRequiresDescribedby', 'tabIndexGreaterThanZero', 'tableHasAppropriateHeaders', 'uncontrolledTabpanel', 'unfocusableElementsWithOnClick', 'unsupportedAriaAttribute', 'videoWithoutCaptions' ], auditRulesToIgnore: [] } }, package: 'protractor-accessibility-plugin'

some plugins is not working...

// 'nonExistentAriaLabelledbyElement', -> is on the docs, but does not exist

auditRulesToIgnore - on docs this property is pointed as auditRulesToSkip

The error log when we add the nonExistentAriaLabelledbyElement rule :

[16:07:52] I/plugins - Fail: protractor-accessibility-plugin Plugin Tests [16:07:52] E/plugins - Failure during teardown: unknown error: Cannot read property 'canRun' of null (Session info: chrome=55.0.2883.87) (Driver info: chromedriver=2.26.436362 (5476ec6bf7ccbada1734a0cdec7d570bb042aa30),platform=Windows NT 10.0.14393 x86_64) [16:07:52] E/plugins - WebDriverError: unknown error: Cannot read property 'canRun' of null (Session info: chrome=55.0.2883.87) (Driver info: chromedriver=2.26.436362 (5476ec6bf7ccbada1734a0cdec7d570bb042aa30),platform=Windows NT 10.0.14393 x86_64) at Object.checkLegacyResponse (C:\projects\transempregos\node_modules\selenium-webdriver\lib\error.js:639:15) at parseHttpResponse (C:\projects\transempregos\node_modules\selenium-webdriver\http\index.js:538:13) at client_.send.then.response (C:\projects\transempregos\node_modules\selenium-webdriver\http\index.js:472:11) at ManagedPromise.invokeCallback_ (C:\projects\transempregos\node_modules\selenium-webdriver\lib\promise.js:1379:14) at TaskQueue.execute_ (C:\projects\transempregos\node_modules\selenium-webdriver\lib\promise.js:2913:14) at TaskQueue.executeNext_ (C:\projects\transempregos\node_modules\selenium-webdriver\lib\promise.js:2896:21) at asyncRun (C:\projects\transempregos\node_modules\selenium-webdriver\lib\promise.js:2820:25) at C:\projects\transempregos\node_modules\selenium-webdriver\lib\promise.js:639:7 at process._tickCallback (internal/process/next_tick.js:103:7) From: Task: a11y developer tool rules at Driver.schedule (C:\projects\transempregos\node_modules\selenium-webdriver\lib\webdriver.js:377:17) at ProtractorBrowser.executeScriptWithDescription (C:\projects\transempregos\node_modules\protractor\built\browser.js:210:28) at runChromeDevTools (C:\projects\transempregos\node_modules\protractor-accessibility-plugin\index.js:172:18) at Object.teardown (C:\projects\transempregos\node_modules\protractor-accessibility-plugin\index.js:66:17) at resolver (C:\projects\transempregos\node_modules\protractor\built\plugins.js:197:49) at Function.promise (C:\projects\transempregos\node_modules\q\q.js:682:9) at Plugins.safeCallPluginFun (C:\projects\transempregos\node_modules\protractor\built\plugins.js:209:49) at C:\projects\transempregos\node_modules\protractor\built\plugins.js:221:30 at Array.map (native) at Plugins.teardown (C:\projects\transempregos\node_modules\protractor\built\plugins.js:220:18) [16:07:52] I/launcher - 0 instance(s) of WebDriver still running [16:07:52] I/launcher - chrome #01 failed 1 test(s) [16:07:52] I/launcher - overall: 1 failed spec(s) [16:07:52] E/launcher - Process exited with error code 1 [16:07:52] { [Error: protractor exited with code 1] message: 'protractor exited with code 1', showStack: false, showProperties: true, plugin: 'gulp-protractor', __safety: { toString: [Function: bound ] } } [16:07:52] 'test:acceptance' errored after 6.25 s [16:07:52] Error in plugin 'gulp-protractor'

lleitep3 added a commit to lleitep3/protractor-accessibility-plugin that referenced this issue Jan 10, 2017
fix doc info about issue angular#20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant