Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

fixed timeline plugin to work with protractor 3.x and 4.x #8

Closed
wants to merge 1 commit into from

Conversation

metrophos
Copy link

'executor' returns now a promise instead of a callback.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@metrophos
Copy link
Author

I signed it!

2016-11-02 13:23 GMT+01:00 googlebot notifications@github.com:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#8 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHxzX9uS3gzC3PTf00qkmebILIEiV4Juks5q6IC9gaJpZM4KnLNW
.

@phamdt
Copy link

phamdt commented Nov 2, 2016

do we know if this works with pre 3.3 including 2.x? do we need it to?

@sjelin
Copy link
Contributor

sjelin commented Nov 7, 2016

Merged in (highly edited version) at 35e3e53. This should work with all versions of protractor

@sjelin sjelin closed this Nov 7, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants