feat(browser): auto-unwrap ElementFinder into WebElement for selenium…

… funtions (#3471)
angular · Aug 22, 2016 · c5faf08 · c5faf08
1 parent a379b33
commit c5faf08
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 5 deletions.
diff --git a/lib/browser.ts b/lib/browser.ts
@@ -51,16 +51,22 @@ export class Webdriver {
 
 /**
  * Mix a function from one object onto another. The function will still be
- * called in the context of the original object.
+ * called in the context of the original object.  Any arguments of type
+ * `ElementFinder` will be unwrapped to their underlying `WebElement` instance
  *
  * @private
  * @param {Object} to
  * @param {Object} from
  * @param {string} fnName
  * @param {function=} setupFn
  */
-function mixin(to: any, from: any, fnName: string, setupFn?: Function) {
+function ptorMixin(to: any, from: any, fnName: string, setupFn?: Function) {
   to[fnName] = function() {
+    for (var i = 0; i < arguments.length; i++) {
+      if (arguments[i] instanceof ElementFinder) {
+        arguments[i] = arguments[i].getWebElement();
+      }
+    }
     if (setupFn) {
       setupFn();
     }
@@ -265,11 +271,11 @@ export class ProtractorBrowser extends Webdriver {
         .forEach((method: string) => {
           if (!this[method] && typeof webdriverInstance[method] == 'function') {
             if (methodsToSync.indexOf(method) !== -1) {
-              mixin(
+              ptorMixin(
                   this, webdriverInstance, method,
                   this.waitForAngular.bind(this));
             } else {
-              mixin(this, webdriverInstance, method);
+              ptorMixin(this, webdriverInstance, method);
             }
           }
         });
@@ -863,7 +869,7 @@ export class ProtractorBrowser extends Webdriver {
    */
   navigate() {
     let nav = this.driver.navigate();
-    mixin(nav, this, 'refresh');
+    ptorMixin(nav, this, 'refresh');
     return nav;
   }
 

diff --git a/spec/basic/lib_spec.js b/spec/basic/lib_spec.js
@@ -44,6 +44,12 @@ describe('protractor library', function() {
         expect(browser.driver.getCurrentUrl()).toMatch('#/form');
       });
 
+  it('should unwrap WebElements', function() {
+    browser.get('index.html');
+    var ptorEl = element(by.binding('greet'));
+    browser.executeScript('', ptorEl); // Will crash if element isn't unwrapped
+  });
+
   it('should have access to the processed config block', function() {
     function containsMatching(arr, string) {
       var contains = false;