Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should by.exactRepeater also split by "="? #2335

Closed
alecxe opened this issue Jul 13, 2015 · 2 comments
Closed

Should by.exactRepeater also split by "="? #2335

alecxe opened this issue Jul 13, 2015 · 2 comments

Comments

@alecxe
Copy link
Contributor

alecxe commented Jul 13, 2015

Following up http://stackoverflow.com/questions/31389521/protractor-by-repeater-not-finding-anything.

There is the following repeater:

item in filteredItems = (items | filter:'abc')

Currently, it is not possible to locate it by:

element.all(by.exactRepeater("item in filteredItems"));

We had to include everything before the pipe:

element.all(by.exactRepeater("item in filteredItems = (items"));

This is because the findAllRepeaterRows() "client side" function splits by "track by", "|" and "as" only:

return ngRepeat.split(' track by ')[0].split(' as ')[0].split('|')[0].trim() == repeater;

Should it also split by the equal sign =?

Thank you.

@sjelin
Copy link
Contributor

sjelin commented Jul 13, 2015

Good catch

sjelin added a commit to sjelin/protractor that referenced this issue Jul 13, 2015
sjelin added a commit to sjelin/protractor that referenced this issue Jul 13, 2015
@sjelin sjelin closed this as completed in b147033 Jul 13, 2015
@alecxe
Copy link
Contributor Author

alecxe commented Jul 13, 2015

That was quick. Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants