Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add runner.ready promise for debugger #3898

Closed
sjelin opened this issue Dec 30, 2016 · 0 comments
Closed

Add runner.ready promise for debugger #3898

sjelin opened this issue Dec 30, 2016 · 0 comments
Labels
difficulty: easy hotlist: polish status: pr pending type: enhancement
Projects
Support ControlFlow-less Selenium

Comments

@sjelin
Copy link
Contributor

sjelin commented Dec 30, 2016 •
edited

Right now we have the Control Flow wait 1 second if the debugger is being used. When the control flow is turned off this obviously isn't going to work. We can add a runner.ready promise to deal with this problem easily.
sjelin added a commit to sjelin/protractor that referenced this issue Jan 25, 2017
@sjelin
chore(runner): wait for debugger using then block
d0d954f 
Closes angular#3898
sjelin added a commit to sjelin/protractor that referenced this issue Jan 25, 2017
@sjelin
chore(runner): wait for debugger using then block
d3003f0 
Closes angular#3898
@sjelin sjelin mentioned this issue Jan 26, 2017
Merged
sjelin added a commit that referenced this issue Jan 26, 2017
@sjelin
chore(runner): wait for debugger using then block (#4014)
cbbae47 
Closes #3898
sjelin added a commit that referenced this issue Jan 26, 2017
@sjelin
chore(runner): wait for debugger using then block (#4014)
d1266da 
Closes #3898
@sjelin sjelin closed this as completed in 41b4fcc Jan 27, 2017
igniteram pushed a commit to igniteram/protractor that referenced this issue Feb 21, 2017
@sjelin @igniteram
chore(runner): wait for debugger using then block (angular#4014)
4cd0814 
Closes angular#3898
bodyduardU pushed a commit to bodyduardU/protractor that referenced this issue Dec 5, 2022
@sjelin
chore(runner): wait for debugger using then block (#4014)
cd0fb0c 
Closes angular/protractor#3898
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy hotlist: polish status: pr pending type: enhancement
Projects
Support ControlFlow-less Selenium
Stage 1: Internals (issues)
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sjelin