Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CircleCI is broken due to drag and drop issue #4385

Closed
heathkit opened this issue Jul 15, 2017 · 7 comments
Closed

CircleCI is broken due to drag and drop issue #4385

heathkit opened this issue Jul 15, 2017 · 7 comments
Assignees
Labels

Comments

@heathkit
Copy link
Contributor

Our CircleCI build is failing. The test that's failing is "using an ActionSequence should drag and drop" from basicConf.js. I'm guessing this is due to a change in selenium webdriver around the actions API. It would be good to get this fixed so we can get a passing CI run again. If it's a big unfeasible problem, marking the test pending and referencing this issue would also be fine, as long as we investigate what's happening.

@wswebcreation wswebcreation self-assigned this Jul 16, 2017
@wswebcreation
Copy link
Contributor

Will dive into it the coming days and create a PR for it

@wswebcreation
Copy link
Contributor

wswebcreation commented Jul 16, 2017

Hi @heathkit ,

I checked this and I think it's related to #583. What I see in the testapp of Protractor is that the html 5 slider is working, but it will only go to value 5. It doesn't mater if you try to slide it to 1000px to the right, it will still stick on 5.

We now have a few options:

  1. change expected value 10 to 5. We know the drag and drop work, only not with HTML5 sliders due to a Chromedriver issue (maybe we can also close issue 583). Also refer to HTML5 dragging does not always work on Chrome #583 in a comment in the test why we adjusted it to 5.
  2. accept that is wont work and skip this test

I'm more in favour of 1 because the dag and drop does work (set some sleeps into it to see if it's working and it's working), only not completely due to #583.

Like to hear what you think

@BassemDev
Copy link

@heathkit do you face a problem with getCurrentUrl in circleCi with chrome, i can't get the new url after login to the home page it's always sending the old url which mean the /signIn page ?
I don't know the reason but with firefox on circleCi and locally (on my mac) everything works fine.
could you maybe share an example where you use getCurrentUrl on circleCi after signIn. meanWhile this is an example of my code:

import { browser, Config, element, by } from 'protractor';
import { assert } from 'chai';

describe('test sample', function() {

    function urlChanged(url) {
            return function () {
                return browser.getCurrentUrl().then(function(actualUrl) {
                    return url != actualUrl;
                });
            };
    };

    beforeEach(function() {
        browser.ignoreSynchronization = true;
    });

    it('should login', function() {
        browser.get('http://localhost:8080/#/signin');
        const email = element(by.name('email'));
        const password = element(by.name('password'));
        const button = element(by.css('[type="submit"]'));
        email.sendKeys('qa-test@fashion.cloud');
        password.sendKeys('fc123456789');
        button.click();
        browser.wait(urlChanged('http://localhost:8080/#/signin'), 30000);
        browser.getCurrentUrl().then((url) => {
            console.log('url is', url);
        });
    });
});

@wswebcreation
Copy link
Contributor

@BassemDev

Tnx for the info, but it's better to mention it in your own issue. This issue is mainly for the drag and drop of a HTML5 slider with chrome, not an issue with the getCurrentUrl()

@BassemDev
Copy link

@wswebcreation , i am not trying to mention it here but this is just a simple question for @heathkit to see if he also face the same issues or not with that method since this issues is also related to CircleCi behaviour with chrome. (i also update and explain more in my issues)

@cnishina
Copy link
Member

cnishina commented Jul 31, 2017

"Fixed" with xit. Should revisit SeleniumHQ/selenium#3693 in the future to fix our action_spec.js. See 768fd39 for the "fix".

We should close this issue and create a new one to change our action_spec back in the future.

@wswebcreation
Copy link
Contributor

Created a new issue for removing the xit and closed this one as asked by @cnishina

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants