This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
fix: fix all locator examples #4413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaced all `browser.findElement(..)` for `element(..)`
|
When looking @ this PR, can you also please check #4385 (comment) for the broken circleCI? |
|
This makes sense. We are trying to tell our users that these are inherited by the Protractor locator I like it. 😄 |
cnishina
approved these changes
Jul 30, 2017
|
Tnx, I did a webinar last week and saw this during my demo. It made people confuse, because they now saw different implementations. I think this would be more consistent. |
|
What about the circleCI? Shall I also change that with a PR? |
|
Hmmm... I don't think your changes should cause errors in the test suite. I plan to rerun circle then merge it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaced all
browser.findElement(..)forelement(..)to make the API documentation more consistent