Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DriverProvider for local: No option to set gecko driver #4411

Closed
cnishina opened this issue Jul 29, 2017 · 0 comments · Fixed by #4412
Closed

DriverProvider for local: No option to set gecko driver #4411

cnishina opened this issue Jul 29, 2017 · 0 comments · Fixed by #4412

Comments

@cnishina
Copy link
Member

cnishina commented Jul 29, 2017 •
edited
Loading

We check to see if chrome is set as a capability and use it when launching locally but no other drivers are provided. At a minimum we might want to also include gecko driver.

https://github.com/angular/protractor/blob/master/lib/driverProviders/local.ts#L59

We should allow for the driver path via the config file and if not to default to the webdriver-manager's downloaded binaries.
@cnishina cnishina changed the title Launch gecko driver with local missing DriverProvider for local: No option to set gecko driver Jul 29, 2017
@cnishina cnishina mentioned this issue Jul 29, 2017
Closed
cnishina added a commit to cnishina/protractor that referenced this issue Jul 29, 2017
@cnishina
fix(local): allow local driver provider to use gecko driver from config
06718e8 
- Add gecko driver as configuration option to be used in the local
  driver provider.
- Nit fixes to use string[] over Array<string> in the configParser.ts
- Add functionality to addDefaultBinaryLocs_ to use the geckoDriver
  value set in the config or to check locally in the
  webdriver-manager/selenium folder

closes angular#4408 and closes angular#4411.
@cnishina cnishina mentioned this issue Jul 29, 2017
Merged
cnishina added a commit to cnishina/protractor that referenced this issue Jul 30, 2017
@cnishina
fix(local): allow local driver provider to use gecko driver from config
a451834 
- Add gecko driver as configuration option to be used in the local
  driver provider.
- Nit fixes to use string[] over Array<string> in the configParser.ts
- Add functionality to addDefaultBinaryLocs_ to use the geckoDriver
  value set in the config or to check locally in the
  webdriver-manager/selenium folder

closes angular#4408 and closes angular#4411.
cnishina added a commit to cnishina/protractor that referenced this issue Jul 30, 2017
@cnishina
fix(local): allow local driver provider to use gecko driver from config
bec33ad 
- Add gecko driver as configuration option to be used in the local
  driver provider.
- Nit fixes to use string[] over Array<string> in the configParser.ts
- Add functionality to addDefaultBinaryLocs_ to use the geckoDriver
  value set in the config or to check locally in the
  webdriver-manager/selenium folder
- Fix transpile errors in locator. Missing toString in ProtractorLocator
  interface
- Fix transpile errors in element. Cast wdpromise.Promise<{}> to
  wdpromise.Promise<T>

closes angular#4408 and closes angular#4411.
cnishina added a commit to cnishina/protractor that referenced this issue Jul 30, 2017
@cnishina
fix(local): allow local driver provider to use gecko driver from config
db0dd1b 
- Add gecko driver as configuration option to be used in the local
  driver provider.
- Nit fixes to use string[] over Array<string> in the configParser.ts
- Add functionality to addDefaultBinaryLocs_ to use the geckoDriver
  value set in the config or to check locally in the
  webdriver-manager/selenium folder
- Fix transpile errors in locator. Missing toString in ProtractorLocator
  interface
- Fix transpile errors in element. Cast wdpromise.Promise<{}> to
  wdpromise.Promise<T>

closes angular#4408 and closes angular#4411.
cnishina added a commit to cnishina/protractor that referenced this issue Jul 31, 2017
@cnishina
fix(local): allow local driver provider to use gecko driver from config
fbd95d0 
- Add gecko driver as configuration option to be used in the local
  driver provider.
- Nit fixes to use string[] over Array<string> in the configParser.ts
- Add functionality to addDefaultBinaryLocs_ to use the geckoDriver
  value set in the config or to check locally in the
  webdriver-manager/selenium folder
- Fix transpile errors in locator. Missing toString in ProtractorLocator
  interface
- Fix transpile errors in element. Cast wdpromise.Promise<{}> to
  wdpromise.Promise<T>

closes angular#4408 and closes angular#4411.
cnishina added a commit to cnishina/protractor that referenced this issue Jul 31, 2017
@cnishina
fix(local): allow local driver provider to use gecko driver from config
6109760 
- Add gecko driver as configuration option to be used in the local
  driver provider.
- Nit fixes to use string[] over Array<string> in the configParser.ts.
- Add functionality to addDefaultBinaryLocs_ to use the geckoDriver
  value set in the config or to check locally in the
  webdriver-manager/selenium folder.
- Fix transpile errors in locator. Missing toString in ProtractorLocator
  interface.
- Fix transpile errors in element. Cast wdpromise.Promise<{}> to
  wdpromise.Promise<T>.
- xit spec/basic/action_spec.js based on
  [selenium-webdriver issue angular#3693](SeleniumHQ/selenium#3693).
  Added a // TODO comment to remove xit when selenium-webdriver resolves issue.

closes angular#4408 and closes angular#4411.
cnishina added a commit that referenced this issue Jul 31, 2017
@cnishina
fix(local): allow local driver provider to use gecko driver from conf…
768fd39 
…ig (#4412)

- Add gecko driver as configuration option to be used in the local driver provider. 
- Nit fixes to use `string[]` over `Array<string>` in the configParser.ts.
- Add functionality to `addDefaultBinaryLocs_` to use the `geckoDriver` value
  set in the config or to check locally in the `webdriver-manager/selenium` folder.
- Fix transpile errors in locator. Missing toString in ProtractorLocator interface.
- Fix transpile errors in element. Cast wdpromise.Promise<{}> to wdpromise.Promise<T>.
- xit spec/basic/action_spec.js based on
  [selenium-webdriver issue #3693](SeleniumHQ/selenium#3693). 
  Added a // TODO comment to remove xit when selenium-webdriver resolves issue.

closes #4408 and closes #4411.
@wswebcreation wswebcreation mentioned this issue Aug 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(local): allow local driver provider to use gecko driver from config cnishina/protractor
1 participant
@cnishina