Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a better way for Protractor to sync with Angular #996

Closed
hankduan opened this issue Jun 28, 2014 · 6 comments
Closed

Find a better way for Protractor to sync with Angular #996

hankduan opened this issue Jun 28, 2014 · 6 comments

Comments

@hankduan
Copy link
Contributor

In order to inject mock modules into Angular before it bootstraps, Protractor currently does this:

Protractor changes window.name before navigating to an Angular site. Angular sees this name, halts bootstrap. After Angular injects the mock modules, Angular resumes bootstrap. This would be fine, except window.name isn't persistent across location.assign().

The way protractor is syncing with Angular implies the following:

  1. protractor cannot implement back or forward
  2. if another site redirects to Angular, mock modules will not be injected unless the test reloads Angular (i.e. if non-Angular log in page redirects to Angular app)

Need to think of a new communication protocol between Angular/protractor

@hankduan hankduan added this to the Icebox milestone Jun 28, 2014
@hankduan hankduan self-assigned this Jun 28, 2014
@Droogans
Copy link

I personally would love to see graceful degradation of Protractor's functionalities if you were to navigate to a non-angular app. Right now, some links are like landmines in that they crash the entire test if you click them.

@ishmaelthedestroyer
Copy link

+1

@hankduan
Copy link
Contributor Author

hankduan commented Aug 4, 2014

see #1155

@juliemr
Copy link
Member

juliemr commented Mar 17, 2015

Removing needs investigation, since this is in icebox.

@juliemr
Copy link
Member

juliemr commented Sep 23, 2015

Examples of issues that this causes:

#2461
#2076

@juliemr
Copy link
Member

juliemr commented Dec 22, 2016

Closing in favor of #3374

@juliemr juliemr closed this as completed Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants